From: Chris Ball <cjb@laptop.org>
To: Daniel Drake <dsd@laptop.org>
Cc: linux-mmc@vger.kernel.org, kliu5@marvell.com, jlfu@marvell.com
Subject: Re: [PATCH] sdhci-pxav3: Fix runtime PM initialization
Date: Thu, 27 Jun 2013 11:47:34 -0400 [thread overview]
Message-ID: <877ghfo8rt.fsf@octavius.laptop.org> (raw)
In-Reply-To: <20130610201618.C08C3FAACC@dev.laptop.org> (Daniel Drake's message of "Mon, 10 Jun 2013 16:16:18 -0400 (EDT)")
Hi Daniel,
On Mon, Jun 10 2013, Daniel Drake wrote:
> Commit bb691ae464b77d30e74c66480e98d74e88d6b194 breaks boot on OLPC XO-4,
> it hangs somewhere inside sdhci_add_host.
>
> When pm_runtime_set_autosuspend_delay() was being called, the device's usage
> counter was 0, causing the PM layer to runtime-suspend the device. We then
> went on to call sdhci_add_host() on a suspended device, which hung.
>
> Fix this by making the driver consistent with the omap_hsmmc driver, both
> in terms of runtime PM initialization and error handling. Now the device
> is not runtime-suspended until we exit the probe routine.
>
> Signed-off-by: Daniel Drake <dsd@laptop.org>
Thanks for the fix, pushed to mmc-next for 3.11.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2013-06-27 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 20:16 [PATCH] sdhci-pxav3: Fix runtime PM initialization Daniel Drake
2013-06-27 15:47 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ghfo8rt.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=dsd@laptop.org \
--cc=jlfu@marvell.com \
--cc=kliu5@marvell.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox