Re: [PATCH v6 07/14] mmc: host: adjust uhs timing value

[Chris Ball <cjb@laptop.org>]

Hi,

On Wed, Oct 17 2012, Kevin Liu wrote:
> From: Kevin Liu <kliu5@marvell.com>
>
> Both of MMC_TIMING_LEGACY and MMC_TIMING_UHS_SDR12 are defined
> to 0. And ios->timing is set to MMC_TIMING_LEGACY during power up.
> But set_ios can't distinguish these two timing if host support
> spec 3.0. Just adjust timing values to be different can resolve
> this issue without any other impact.
>
> Reviewed By: Girish K S <girish.shivananjappa@linaro.org>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: Kevin Liu <kliu5@marvell.com>
> ---
>  include/linux/mmc/host.h |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
> index 7abb0e1..8f5f6c0 100644
> --- a/include/linux/mmc/host.h
> +++ b/include/linux/mmc/host.h
> @@ -53,12 +53,12 @@ struct mmc_ios {
>  #define MMC_TIMING_LEGACY	0
>  #define MMC_TIMING_MMC_HS	1
>  #define MMC_TIMING_SD_HS	2
> -#define MMC_TIMING_UHS_SDR12	MMC_TIMING_LEGACY
> -#define MMC_TIMING_UHS_SDR25	MMC_TIMING_SD_HS
> -#define MMC_TIMING_UHS_SDR50	3
> -#define MMC_TIMING_UHS_SDR104	4
> -#define MMC_TIMING_UHS_DDR50	5
> -#define MMC_TIMING_MMC_HS200	6
> +#define MMC_TIMING_UHS_SDR12	3
> +#define MMC_TIMING_UHS_SDR25	4
> +#define MMC_TIMING_UHS_SDR50	5
> +#define MMC_TIMING_UHS_SDR104	6
> +#define MMC_TIMING_UHS_DDR50	7
> +#define MMC_TIMING_MMC_HS200	8
>  
>  #define MMC_SDR_MODE		0
>  #define MMC_1_2V_DDR_MODE	1

Thanks, pushed to mmc-next for 3.8.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child