Re: [PATCH 5/5] OMAP: devices: Modify HSMMC device to adapt to hwmod framework

Kevin Hilman
2011-02-10T21:10:43Z

"Kadiyala, Kishore" <kishore.kadiyala@ti.com> writes:

[...]

>
>>
>> The board code should simply call some mmc init routine optionally
>> passing int the platform_data, just like is done for hsmmc_init.
>>
>> With common hwmod data, shouldn't it be possible to unify the init of
>> MMC and HS-MMC controllers?
>
> The init of MMC & HS-MMC are different.

> HSMMC supported boards, the board file fills an intermediate structure
> omap2_hsmmc_info which is used by the hsmmc.c file to update the
> omap_mmc_platform_data.
>
> MMC supported boards, the board file fills the omap_mmc_platform_data.

Yes, I understand how they are different _today_. My question is that
now that we're using hwmod, is there any real reason they need to remain
different.

>
> Ok, will try to keep an API common for init of both MMC & HSMMC
>

Thanks,

Kevin