From: Chris Ball <cjb@laptop.org>
To: Aaron Lu <aaron.lu@amd.com>
Cc: linux-mmc@vger.kernel.org, Aaron Lu <aaron.lwe@gmail.com>,
Philip Rakity <prakity@marvell.com>
Subject: Re: [PATCH v3 2/2] mmc: sdhci: A new flag SDHCI_USING_RETUNING_TIMER
Date: Mon, 09 Jul 2012 22:55:01 -0400 [thread overview]
Message-ID: <87a9z8uxyy.fsf@octavius.laptop.org> (raw)
In-Reply-To: <20120704052909.GB2607@aarontestpc.amd.com> (Aaron Lu's message of "Wed, 4 Jul 2012 13:29:09 +0800")
Hi Aaron,
On Wed, Jul 04 2012, Aaron Lu wrote:
> Add a new flag of SDHCI_USING_RETUNING_TIMER to represent if the host
> is using a retuning timer for the card inserted.
>
> This flag is set when the host does tuning the first time for the card
> and the host's retuning mode is 1. This flag is used afterwards whenever
> needs to decide if the host is currently using a retuning timer.
>
> This flag is cleared when the card is removed in sdhci_reinit.
>
> The set/clear of the flag and the start/stop of the retuning timer is
> associated with the card's init/remove time, so there is no need to
> touch it when the host is to be removed as at that time the card should
> have already been removed.
>
> Signed-off-by: Aaron Lu <aaron.lu@amd.com>
> ---
> v3:
> Change the macro name from SDHCI_NEEDS_RETUNING_TIMER to
> SDHCI_USING_RETUNING_TIMER for better description of the flag as suggested
> by Chris Ball.
Thanks, pushed to mmc-next for 3.6.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-07-10 2:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 8:17 [PATCH v2 0/2] Fixes for tuning stuffs Aaron Lu
2012-06-29 8:17 ` [PATCH v2 1/2] mmc: sdhci: restore host settings when card is removed Aaron Lu
2012-07-04 0:40 ` Chris Ball
2012-06-29 8:17 ` [PATCH v2 2/2] mmc: sdhci: A new flag SDHCI_NEEDS_RETUNING_TIMER Aaron Lu
2012-07-04 0:46 ` Chris Ball
2012-07-04 5:29 ` [PATCH v3 2/2] mmc: sdhci: A new flag SDHCI_USING_RETUNING_TIMER Aaron Lu
2012-07-04 7:14 ` Girish K S
2012-07-09 5:10 ` Philip Rakity
2012-07-10 2:55 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9z8uxyy.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=aaron.lu@amd.com \
--cc=aaron.lwe@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox