From: Chris Ball <cjb@laptop.org>
To: Will Newton <will.newton@gmail.com>
Cc: Seungwon Jeon <tgih.jun@samsung.com>,
linux-mmc@vger.kernel.org, James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH] mmc: dw_mmc: Fix switch from DMA to PIO
Date: Tue, 10 Apr 2012 10:18:54 -0400 [thread overview]
Message-ID: <87aa2jwtyp.fsf@laptop.org> (raw)
In-Reply-To: <CAFbHwiRAE0G9Yr5Af5cUGsAxw8VNFu0s_NWQ6T3NsLZwGX_Y0Q@mail.gmail.com> (Will Newton's message of "Tue, 10 Apr 2012 10:54:22 +0100")
Hi,
On Tue, Apr 10 2012, Will Newton wrote:
> On Tue, Apr 10, 2012 at 1:53 AM, Seungwon Jeon <tgih.jun@samsung.com> wrote:
>> When dw_mci_pre_dma_transfer returns failure in some reasons,
>> dw_mci_submit_data will prepare to switch the PIO mode from DMA.
>> After switching to PIO mode, DMA(IDMAC in particular) is still
>> enabled. This makes the corruption in handling interrupt and
>> the driver lock-up.
>>
>> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
>
> This looks ok to me.
>
> Acked-by: Will Newton <will.newton@imgtec.com>
Thanks, pushed to mmc-next for 3.4.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-04-10 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 0:53 [PATCH] mmc: dw_mmc: Fix switch from DMA to PIO Seungwon Jeon
2012-04-10 9:54 ` Will Newton
2012-04-10 14:18 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa2jwtyp.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=james.hogan@imgtec.com \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).