From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B85C433EF for ; Fri, 8 Apr 2022 08:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231360AbiDHIQo (ORCPT ); Fri, 8 Apr 2022 04:16:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231345AbiDHIQm (ORCPT ); Fri, 8 Apr 2022 04:16:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6960360D87; Fri, 8 Apr 2022 01:14:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 054B3615A7; Fri, 8 Apr 2022 08:14:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31BDFC385A1; Fri, 8 Apr 2022 08:14:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649405678; bh=DXntX2Jz7Nztnd1dMcRMCaGMy0UPIH0WJlp5HA4774s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Qu+tD/xH27JIeXTaUKCquAn5fQayD4kxRqf9nIEs5/Z/nJRRkNrYMgZhuJZXKt8Al NkLhsVjHZOQo7GV7TnXxgY/OhKOkJU3Osmzr9x7wxOTEUJqNBpdfoz4FPDWMUGX/64 u5jSI6cp8wrTBzl12n2nao2HO36tXUvV7ocDKe08fD9PBw+bB24wUGrlfy8Po3axfC 48EribHBfxK/csfTD4gSi23AoDNCMmpAeki/n+TADylKpJEf3htCMIfhNEuUqVJq8e vepktCqnHgHTjfdLOMttvcbqtGvHV3pvfSY79LhuYzJ1SgqriOd3dpsluPlBAmvsnT YOSlmsHLEDPGA== From: Kalle Valo To: Wolfram Sang Cc: linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Ulf Hansson , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Arend van Spriel , Franky Lin , Hante Meuleman , Amitkumar Karwar , Ganapathi Bhat , Sharvari Harisangam , Xinming Hu , linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com Subject: Re: [PATCH 1/3] mmc: core: improve API to make clear mmc_hw_reset is for cards References: <20220408080045.6497-1-wsa+renesas@sang-engineering.com> <20220408080045.6497-2-wsa+renesas@sang-engineering.com> Date: Fri, 08 Apr 2022 11:14:31 +0300 In-Reply-To: <20220408080045.6497-2-wsa+renesas@sang-engineering.com> (Wolfram Sang's message of "Fri, 8 Apr 2022 10:00:42 +0200") Message-ID: <87bkxcouu0.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Wolfram Sang writes: > To make it unambiguous that mmc_hw_reset() is for cards and not for > controllers, we make the function argument mmc_card instead of mmc_host. > Also, all users are converted. > > Suggested-by: Ulf Hansson > Signed-off-by: Wolfram Sang > --- > > Ulf prefers one cross-subsystem patch to have all users converted. So, > we are looking for ACKs from the maintainers of the wireless drivers. > Thank you! > > Changes since RFC: > * don't rename the function but only change the argument type > * remove fallback and convert all users in one go > * remove comment as suggested by Ulf > > drivers/mmc/core/block.c | 2 +- > drivers/mmc/core/core.c | 5 +++-- > drivers/mmc/core/mmc_test.c | 3 +-- > drivers/net/wireless/ath/ath10k/sdio.c | 2 +- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- > drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +- > drivers/net/wireless/ti/wlcore/sdio.c | 2 +- For wireless: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches