From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 1/2 v2] ARM: shmobile: lager: add gpio/fixed regulator for SDHI
Date: Mon, 18 Nov 2013 21:14:15 -0800 (PST)
Message-ID: <87bo1hdlcs.wl%kuninori.morimoto.gx@renesas.com>
References: <87li0rz3to.wl%kuninori.morimoto.gx@renesas.com>
	<87a9h6o2gi.wl%kuninori.morimoto.gx@renesas.com>
	<878uwqo2df.wl%kuninori.morimoto.gx@renesas.com>
	<7870553.GWO3OgcztQ@avalon>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-sh-owner@vger.kernel.org>
In-Reply-To: <7870553.GWO3OgcztQ@avalon>
Sender: linux-sh-owner@vger.kernel.org
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Simon <horms@verge.net.au>, Chris Ball <cjb@laptop.org>, Magnus <magnus.damm@gmail.com>, Linux-SH <linux-sh@vger.kernel.org>, Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>, linux-mmc@vger.kernel.org
List-Id: linux-mmc@vger.kernel.org


Hi Laurent

> >  #include <linux/platform_data/rcar-du.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/phy.h>
> > +#include <linux/regulator/driver.h>
> 
> I might be mistaken, but is this header really needed ?

Unfortunately, the compile will error without it.
regulator_xxx / REGULATOR_XXX need it

> > +static struct fixed_voltage_config vcc_sdhi##idx##_info = {		\
> 
> You can make this structure const.
(snip)
> > +static struct gpio_regulator_config vccq_sdhi##idx##_info = {		\
> 
> You can make this structure const.

I see.
Thank you

Best regards
---
Kuninori Morimoto