From: Chris Ball <cjb@laptop.org>
To: Seungwon Jeon <tgih.jun@samsung.com>
Cc: 'Sachin Kamat' <sachin.kamat@linaro.org>,
linux-mmc@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH v2 1/2] mmc: dw_mmc: Check return value of regulator_enable
Date: Thu, 04 Apr 2013 10:18:52 -0400 [thread overview]
Message-ID: <87bo9upeer.fsf@octavius.laptop.org> (raw)
In-Reply-To: <004701ce30fb$353ce1b0$9fb6a510$%jun@samsung.com> (Seungwon Jeon's message of "Thu, 04 Apr 2013 15:11:12 +0900")
Hi,
On Thu, Apr 04 2013, Seungwon Jeon wrote:
> On Thursday, April 04, 2013, Sachin Kamat wrote:
>> regulator_enable() is declared with __must_check attribute.
>> Hence check the return value to ensure that the regulator is enabled.
>> Fixes the following warning:
>> drivers/mmc/host/dw_mmc.c:2461:19: warning:
>> ignoring return value of ‘regulator_enable’, declared with attribute
>> warn_unused_result [-Wunused-result]
>> drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_init_slot’:
>> drivers/mmc/host/dw_mmc.c:1994:19: warning:
>> ignoring return value of ‘regulator_enable’, declared with attribute
>> warn_unused_result [-Wunused-result]
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
Thanks, both patches pushed to mmc-next for 3.10.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2013-04-04 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 5:55 [PATCH v2 1/2] mmc: dw_mmc: Check return value of regulator_enable Sachin Kamat
2013-04-04 5:55 ` [PATCH v2 2/2] mmc: dw_mmc: Use pr_info instead of printk Sachin Kamat
2013-04-04 6:11 ` [PATCH v2 1/2] mmc: dw_mmc: Check return value of regulator_enable Seungwon Jeon
2013-04-04 14:18 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo9upeer.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox