From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH v3] MMC: SD/MMC Host Controller for Wondermedia WM8505/WM8650 Date: Sun, 18 Nov 2012 13:08:51 -0500 Message-ID: <87boeuiy18.fsf@octavius.laptop.org> References: <1353205986-23476-1-git-send-email-linux@prisktech.co.nz> <87k3tjipmi.fsf@octavius.laptop.org> <1353260664.23933.0.camel@gitbox> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from void.printf.net ([89.145.121.20]:39479 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073Ab2KRSI5 (ORCPT ); Sun, 18 Nov 2012 13:08:57 -0500 In-Reply-To: <1353260664.23933.0.camel@gitbox> (Tony Prisk's message of "Mon, 19 Nov 2012 06:44:24 +1300") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Tony Prisk Cc: arm-linux-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, vt8500-wm8505-linux-kernel@googlegroups.com Hi, On Sun, Nov 18 2012, Tony Prisk wrote: >> On Sat, Nov 17 2012, Tony Prisk wrote: >> > + regular_irq = irq_of_parse_and_map(np, 0); >> > + dma_irq = irq_of_parse_and_map(np, 1); >> > + >> > + if ((!regular_irq) | (!dma_irq)) { >> > + dev_err(&pdev->dev, "Getting IRQs failed!\n"); >> >> I think you meant ||, not |, and you could remove the redundant parens. >> >> Other than that, I think this is ready -- if you want to ACK the above >> change I'll fold it in without having you resend the patch. > > Oops - Good catch. > Acked-by: Tony Prisk Thanks, pushed to mmc-next for 3.8. - Chris. -- Chris Ball One Laptop Per Child