From: Chris Ball <cjb@laptop.org>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Micha <mirq-linux@rere.qmqm.pl>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver()
Date: Thu, 01 Dec 2011 14:11:00 -0500 [thread overview]
Message-ID: <87borsjeez.fsf@laptop.org> (raw)
In-Reply-To: <1322283343.14278.2.camel@phoenix> (Axel Lin's message of "Sat, 26 Nov 2011 12:55:43 +0800")
Hi Axel, Micha,
On Fri, Nov 25 2011, Axel Lin wrote:
> This patch converts the drivers in drivers/mmc/host/* to use the
> module_platform_driver() macro which makes the code smaller and a bit
> simpler.
This makes cb710_mmc unhappy:
/home/cjb/git/mmc/drivers/mmc/host/cb710-mmc.c:783:1: warning: data definition has no type or storage class [enabled by default]
/home/cjb/git/mmc/drivers/mmc/host/cb710-mmc.c:783:1: warning: type defaults to ‘int’ in declaration of ‘module_platform_driver’ [-Wimplicit-int]
/home/cjb/git/mmc/drivers/mmc/host/cb710-mmc.c:783:1: warning: parameter names (without types) in function declaration [enabled by default]
/home/cjb/git/mmc/drivers/mmc/host/cb710-mmc.c:773:31: warning: ‘cb710_mmc_driver’ defined but not used [-Wunused-variable]
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-12-01 19:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-26 4:55 [PATCH] mmc: convert drivers/mmc/host/* to use module_platform_driver() Axel Lin
2011-11-26 12:19 ` Anton Vorontsov
2011-11-27 8:58 ` Wolfram Sang
2011-11-27 2:25 ` Micha
2011-11-27 13:42 ` viresh kumar
2011-11-27 21:07 ` Guennadi Liakhovetski
2011-11-28 8:42 ` Sascha Hauer
2011-11-30 23:40 ` David Brown
2011-12-01 19:11 ` Chris Ball [this message]
2011-12-01 23:37 ` Axel Lin
2011-12-02 1:11 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87borsjeez.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox