Re: [PATCHv3 2/3] MMC: OMAP: HSMMC: add runtime pm support

Kevin Hilman
2011-06-30T23:23:12Z

Balaji T K <balajitk@ti.com> writes:

> add runtime pm support to HSMMC host controller
> Use runtime pm API to enable/disable HSMMC clock
> Use runtime autosuspend APIs to enable auto suspend delay
>
> Based on OMAP HSMMC runtime implementation by Kevin Hilman, Kishore Kadiyala
>
> Signed-off-by: Balaji T K <balajitk@ti.com>

Minor nit below...

[...]

> +static int omap_hsmmc_runtime_suspend(struct device *dev)
> +{
> + struct omap_hsmmc_host *host;
> +
> + host = platform_get_drvdata(to_platform_device(dev));
> + omap_hsmmc_context_save(host);
> + dev_dbg(mmc_dev(host->mmc), "disabled\n");
> +
> + return 0;
> +}
> +
> +static int omap_hsmmc_runtime_resume(struct device *dev)
> +{
> + struct omap_hsmmc_host *host;
> +
> + host = platform_get_drvdata(to_platform_device(dev));
> + omap_hsmmc_context_restore(host);
> + dev_dbg(mmc_dev(host->mmc), "host: enabled\n");

Minor: this has a 'host: ' prefix, where as the one in
.runtime_suspend() does not.

> +
> + return 0;
> +}
> +

Kevin