Re: [PATCHv3 0/3] OMAP: HSMMC: cleanup and runtime pm

T Krishnamoorthy, Balaji
2011-07-01T06:16:04Z

On Fri, Jul 1, 2011 at 1:06 AM, Cousson, Benoit <b-cousson@ti.com> wrote:
> Hi Balaji,
>
> On 6/30/2011 9:04 PM, Krishnamoorthy, Balaji T wrote:
>>
>> Removing the custom state machine - lazy disable framework in omap_hsmmc
>> to make way for runtime pm to handle host controller
>> power states.
>> This allows mmc_host_enable/mmc_host_disable to be replaced by
>> runtime get_sync and put_sync at host controller driver.
>>
>> Enable runtime PM in omap_hsmmc
>>
>> Rebased to 3.0-rc5
>> Tested on OMAP4430SDP, OMAP3430SDP, OMAP2430SDP
>>
>> MMC runtime patch has dependency on
>> [PATCH 0/6] OMAP2+: hwmod framework fixes [1]
>> for MMC1/MMC2 clock to get ungated after idle in OMAP4.
>>
>> Without [1] patches, MMC1/MMC2 fails to get detected on OMAP4.
>
> Mmm, that's weird, which one exactly is fixing the issue?

http://www.mail-archive.com/linux-omap@vger.kernel.org/msg51458.html
[PATCH 1/6] OMAP2+: hwmod: Fix smart-standby + wakeup support

http://www.mail-archive.com/linux-omap@vger.kernel.org/msg51461.html
[PATCH 2/6] OMAP4: hwmod data: Add MSTANDBY_SMART_WKUP flag

> BTW, what is the issue exactly?

with SIDLE_SMART_WKUP flag set in omap44xx_mmc_sysc,
module got stuck after second clock enable.
It got resolved after adding MSTANDBY_SMART_WKUP fixes
.
Removing SIDLE_SMART_WKUP also solves the issue..

>
> Benoit
>
>>
>> [1] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg51457.html
>>
>> Balaji T K (3):
>>   MMC: OMAP: HSMMC: Remove lazy_disable
>>   MMC: OMAP: HSMMC: add runtime pm support
>>   MMC: OMAP: HSMMC: Remove unused iclk
>>
>>  drivers/mmc/host/omap_hsmmc.c |  365
>> +++++++----------------------------------
>>  1 files changed, 57 insertions(+), 308 deletions(-)
>>
>
>