From: Chris Ball <cjb@laptop.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawn.guo@linaro.org>,
linux-mmc@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH v2] mmc: sdhci-esdhc-imx: Check the return value from clk_prepare_enable()
Date: Wed, 11 Dec 2013 20:24:51 -0500 [thread overview]
Message-ID: <87eh5i7tek.fsf@octavius.laptop.org> (raw)
In-Reply-To: <CAOMZO5ADVoqiumJFCKWkX=VoS_Uj_VUO0H9V7AK-m2Z1iGJd=w@mail.gmail.com> (Fabio Estevam's message of "Sat, 26 Oct 2013 16:11:45 -0200")
Hi Fabio,
On Sat, Oct 26 2013, Fabio Estevam wrote:
> Chris,
>
> On Sat, Oct 12, 2013 at 4:38 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
>> On Wed, Oct 09, 2013 at 05:37:39PM -0300, Fabio Estevam wrote:
>>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>>
>>> clk_prepare_enable() may fail, so let's check its return value and
>>> propagate it
>>> in the case of error.
>>>
>>> Also, fix the sequence for disabling the clock in the probe error path and
>>> also in the remove funct
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Acked-by: Shawn Guo <shawn.guo@linaro.org>
>
> Any comments on this one?
Looks like this one doesn't apply cleanly anymore, sorry for leaving
it so long -- please could you submit a new version? Thanks.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
prev parent reply other threads:[~2013-12-12 1:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 20:37 [PATCH v2] mmc: sdhci-esdhc-imx: Check the return value from clk_prepare_enable() Fabio Estevam
2013-10-12 7:38 ` Shawn Guo
2013-10-26 18:11 ` Fabio Estevam
2013-12-12 1:24 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh5i7tek.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).