From: Chris Ball <cjb@laptop.org>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Thomas Abraham <thomas.abraham@linaro.org>,
Tomasz Figa <t.figa@samsung.com>,
linux-mmc@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
kgene.kim@samsung.com, ben-linux@fluff.org,
kyungmin.park@samsung.com, m.szyprowski@samsung.com
Subject: Re: [PATCH v2 2/2] mmc: host: sdhci-s3c: Add support for pinctrl
Date: Sun, 25 Nov 2012 15:01:56 -0500 [thread overview]
Message-ID: <87ehjh8n9n.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1596167.a5zz5Y1i9B@flatron> (Tomasz Figa's message of "Sun, 25 Nov 2012 20:37:39 +0100")
Hi,
On Sun, Nov 25 2012, Tomasz Figa wrote:
> Hi Chris,
>
> On Sunday 25 of November 2012 14:22:44 Chris Ball wrote:
>> Hi,
>>
>> On Wed, Nov 21 2012, Thomas Abraham wrote:
>> > nit: there could have been one example each for gpio and pinctrl
>> > variant instead of putting both into one example node.
>>
>> Tomasz, do you want to reply to this review comment?
>
> Well, since Thomas already gave his Acked-by for this patch and the
> comment was only about a minor thing in the documentation, I considered it
> a thing that could be adjusted with further patch if needed.
Okay, that's reasonable -- I'll take it as-is for now. Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-11-25 20:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 14:28 [PATCH v2 0/2] mmc: host: sdhci-s3c: Add support for pinctrl interface Tomasz Figa
2012-11-16 14:28 ` [PATCH v2 1/2] mmc: host: sdhci-s3c: Use devm_gpio_request to request GPIOs Tomasz Figa
2012-11-21 10:52 ` Thomas Abraham
2012-11-16 14:28 ` [PATCH v2 2/2] mmc: host: sdhci-s3c: Add support for pinctrl Tomasz Figa
2012-11-21 10:58 ` Thomas Abraham
2012-11-25 19:22 ` Chris Ball
2012-11-25 19:37 ` Tomasz Figa
2012-11-25 20:01 ` Chris Ball [this message]
2012-11-21 10:40 ` [PATCH v2 0/2] mmc: host: sdhci-s3c: Add support for pinctrl interface Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehjh8n9n.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox