From: Chris Ball <cjb@laptop.org>
To: Girish K S <girish.shivananjappa@linaro.org>
Cc: Ulf Hansson <ulf.hansson@stericsson.com>,
linux-mmc@vger.kernel.org, Per Forlin <per.forlin@stericsson.com>,
Johan Rudholm <johan.rudholm@stericsson.com>,
Lee Jones <lee.jones@linaro.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jasi Brar <jassisinghbrar@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: core: Prevent eMMC VCC supply to be cut from late init
Date: Tue, 10 Jul 2012 13:32:59 -0400 [thread overview]
Message-ID: <87ehojr06s.fsf@octavius.laptop.org> (raw)
In-Reply-To: <CAGxe1ZEnVNLs=sh3kB4w8nvvbGuqowwz9pDtwAdCGLm-M+dKuQ@mail.gmail.com> (Girish K. S.'s message of "Tue, 10 Jul 2012 20:49:04 +0530")
Hi,
On Tue, Jul 10 2012, Girish K S wrote:
>> @@ -2063,7 +2074,8 @@ void mmc_rescan(struct work_struct *work)
>>
>> void mmc_start_host(struct mmc_host *host)
>> {
>> - mmc_power_off(host);
>> + host->f_init = max(freqs[0], host->f_min);
>> + mmc_power_up(host);
>> mmc_detect_change(host, 0);
>> }
>>
> sorry to comment late on this.
> This patch breaks the card detect with the designware host controller.
> Anybody using the same host controller please let me know.
> The problem is caused by the power_up call from the mmc_start_host
> function. If i comment this powerup then card detect is fine
Thanks. Ulf, sounds like we should revert this for 3.5-rc (which would
have to happen soon) while we investigate; let me know what you think.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-07-10 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 14:15 [PATCH] mmc: core: Prevent eMMC VCC supply to be cut from late init Ulf Hansson
2012-05-09 15:56 ` Mark Brown
2012-05-09 16:56 ` Chris Ball
2012-07-10 15:19 ` Girish K S
2012-07-10 17:32 ` Chris Ball [this message]
2012-07-11 12:40 ` Girish K S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehojr06s.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=girish.shivananjappa@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=johan.rudholm@stericsson.com \
--cc=lee.jones@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=per.forlin@stericsson.com \
--cc=ulf.hansson@linaro.org \
--cc=ulf.hansson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox