From: Chris Ball <cjb@laptop.org>
To: Paul Walmsley <paul@pwsan.com>
Cc: Tushar Behera <tushar.behera@linaro.org>,
Tony Lindgren <tony@atomide.com>,
Chase Maupin <Chase.Maupin@ti.com>,
linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org,
sakoman@gmail.com
Subject: Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices
Date: Thu, 12 Apr 2012 14:19:23 -0400 [thread overview]
Message-ID: <87ehrsrexg.fsf@laptop.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1204121130370.29473@utopia.booyaka.com> (Paul Walmsley's message of "Thu, 12 Apr 2012 11:56:06 -0600 (MDT)")
Hi,
On Thu, Apr 12 2012, Paul Walmsley wrote:
>> With this patch, I continuously get following message on my console.
>> (Tested on Origen board, based on EXYNOS4210).
>>
>> mmc0: Too large timeout requested for CMD25!
>>
>> So, with this change, should we update sdhci_calc_timeout() also?
>
> Looks like most of the host drivers that range-check the timeout value
> silently clamp it at the hardware-supported maximum value:
If I understand correctly, the only problem here is the presence of the
warning, so I'm leaning towards just removing it (which we've already
had another request for) or making it pr_debug() instead. Sound okay?
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-04-12 18:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 17:26 [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices Chase Maupin
2012-03-06 12:54 ` Maupin, Chase
2012-03-09 4:38 ` Chris Ball
2012-03-09 13:06 ` Maupin, Chase
2012-03-12 10:58 ` Paul Walmsley
2012-03-12 11:10 ` Paul Walmsley
2012-03-12 14:37 ` Maupin, Chase
2012-03-16 3:22 ` Chris Ball
2012-04-05 22:08 ` Tony Lindgren
2012-04-05 22:15 ` Chris Ball
2012-04-05 23:44 ` Paul Walmsley
2012-04-05 23:54 ` Chris Ball
2012-04-12 9:46 ` Tushar Behera
2012-04-12 17:56 ` Paul Walmsley
2012-04-12 18:19 ` Chris Ball [this message]
2012-04-14 9:38 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehrsrexg.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=Chase.Maupin@ti.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=sakoman@gmail.com \
--cc=tony@atomide.com \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox