public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mmc: core: Update the ext-csd.rev check for eMMC5.1
@ 2013-05-21  9:38 Yuvaraj Kumar C D
  2013-05-23  0:06 ` Doug Anderson
  0 siblings, 1 reply; 4+ messages in thread
From: Yuvaraj Kumar C D @ 2013-05-21  9:38 UTC (permalink / raw)
  To: linux-mmc, cjb, jh80.chung, tgih.jun; +Cc: Yuvaraj Kumar C D, Alim Akhtar

With the new eMMC5.1 spec,there is a new EXT_CSD register with
the revision number(EXT_CSD_REV) 7.This patch updates the check
for ext-csd.rev number as 7.

Signed-off-by: Alim Akhtar <alim.akthar@samsung.com>
Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
---
 drivers/mmc/core/mmc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 0cbd1ef..73f58e0 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -293,7 +293,7 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
 	}
 
 	card->ext_csd.rev = ext_csd[EXT_CSD_REV];
-	if (card->ext_csd.rev > 6) {
+	if (card->ext_csd.rev > 7) {
 		pr_err("%s: unrecognised EXT_CSD revision %d\n",
 			mmc_hostname(card->host), card->ext_csd.rev);
 		err = -EINVAL;
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mmc: core: Update the ext-csd.rev check for eMMC5.1
  2013-05-21  9:38 [PATCH] mmc: core: Update the ext-csd.rev check for eMMC5.1 Yuvaraj Kumar C D
@ 2013-05-23  0:06 ` Doug Anderson
  2013-05-23  0:08   ` Doug Anderson
  0 siblings, 1 reply; 4+ messages in thread
From: Doug Anderson @ 2013-05-23  0:06 UTC (permalink / raw)
  To: Yuvaraj Kumar C D
  Cc: linux-mmc@vger.kernel.org, Chris Ball, Jaehoon Chung,
	Seungwon Jeon, Yuvaraj Kumar C D, Alim Akhtar

Yavaraj,

On Tue, May 21, 2013 at 2:38 AM, Yuvaraj Kumar C D <yuvaraj.cd@gmail.com> wrote:
> With the new eMMC5.1 spec,there is a new EXT_CSD register with
> the revision number(EXT_CSD_REV) 7.This patch updates the check
> for ext-csd.rev number as 7.
>
> Signed-off-by: Alim Akhtar <alim.akthar@samsung.com>
> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
> ---
>  drivers/mmc/core/mmc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks reasonable.

Reviewed-by: Doug Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mmc: core: Update the ext-csd.rev check for eMMC5.1
  2013-05-23  0:06 ` Doug Anderson
@ 2013-05-23  0:08   ` Doug Anderson
  2013-06-27 14:39     ` Chris Ball
  0 siblings, 1 reply; 4+ messages in thread
From: Doug Anderson @ 2013-05-23  0:08 UTC (permalink / raw)
  To: Yuvaraj Kumar C D
  Cc: linux-mmc@vger.kernel.org, Chris Ball, Jaehoon Chung,
	Seungwon Jeon, Yuvaraj Kumar C D, Alim Akhtar

Correction,

On Wed, May 22, 2013 at 5:06 PM, Doug Anderson <dianders@google.com> wrote:
> Yavaraj,
>
> On Tue, May 21, 2013 at 2:38 AM, Yuvaraj Kumar C D <yuvaraj.cd@gmail.com> wrote:
>> With the new eMMC5.1 spec,there is a new EXT_CSD register with
>> the revision number(EXT_CSD_REV) 7.This patch updates the check
>> for ext-csd.rev number as 7.
>>
>> Signed-off-by: Alim Akhtar <alim.akthar@samsung.com>
>> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
>> ---
>>  drivers/mmc/core/mmc.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Looks reasonable.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>

...with the caveat the Alim's email address be corrected.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mmc: core: Update the ext-csd.rev check for eMMC5.1
  2013-05-23  0:08   ` Doug Anderson
@ 2013-06-27 14:39     ` Chris Ball
  0 siblings, 0 replies; 4+ messages in thread
From: Chris Ball @ 2013-06-27 14:39 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Yuvaraj Kumar C D, linux-mmc@vger.kernel.org, Jaehoon Chung,
	Seungwon Jeon, Yuvaraj Kumar C D, Alim Akhtar

Hi,

On Wed, May 22 2013, Doug Anderson wrote:
> Correction,
>
> On Wed, May 22, 2013 at 5:06 PM, Doug Anderson <dianders@google.com> wrote:
>> Yavaraj,
>>
>> On Tue, May 21, 2013 at 2:38 AM, Yuvaraj Kumar C D <yuvaraj.cd@gmail.com> wrote:
>>> With the new eMMC5.1 spec,there is a new EXT_CSD register with
>>> the revision number(EXT_CSD_REV) 7.This patch updates the check
>>> for ext-csd.rev number as 7.
>>>
>>> Signed-off-by: Alim Akhtar <alim.akthar@samsung.com>
>>> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
>>> ---
>>>  drivers/mmc/core/mmc.c |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Looks reasonable.
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>
> ...with the caveat the Alim's email address be corrected.
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>

Thanks, pushed to mmc-next for 3.11 with the corrected signoff.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-06-27 14:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-21  9:38 [PATCH] mmc: core: Update the ext-csd.rev check for eMMC5.1 Yuvaraj Kumar C D
2013-05-23  0:06 ` Doug Anderson
2013-05-23  0:08   ` Doug Anderson
2013-06-27 14:39     ` Chris Ball

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox