From: Chris Ball <cjb@laptop.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Jingoo Han <jg1.han@samsung.com>, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 2/2] mmc: sdhci-spear: add CONFIG_PM_SLEEP to suspend/resume functions
Date: Thu, 04 Apr 2013 10:14:15 -0400 [thread overview]
Message-ID: <87fvz6pemg.fsf@octavius.laptop.org> (raw)
In-Reply-To: <CAOh2x=me7M+pMKQ4O+1BXubfjy4Gq1Pz4EG7-d9nwHoF-vgdzw@mail.gmail.com> (Viresh Kumar's message of "Fri, 29 Mar 2013 12:48:40 +0530")
Hi,
On Fri, Mar 29 2013, Viresh Kumar wrote:
> On Fri, Mar 29, 2013 at 12:38 PM, Jingoo Han <jg1.han@samsung.com> wrote:
>> Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
>> build warning when CONFIG_PM_SLEEP is not selected. This is because
>> sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when
>> the CONFIG_PM_SLEEP is enabled.
>>
>> drivers/mmc/host/sdhci-spear.c:295:12: warning: 'sdhci_suspend'
>> defined but not used [-Wunused-function]
>> drivers/mmc/host/sdhci-spear.c:308:12: warning: 'sdhci_resume'
>> defined but not used [-Wunused-function]
>>
>> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>> ---
>> drivers/mmc/host/sdhci-spear.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Thanks, pushed to mmc-next for 3.10.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2013-04-04 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 7:05 [PATCH 1/2] mmc: atmel-mci: add CONFIG_PM_SLEEP to suspend/resume functions Jingoo Han
2013-03-29 7:08 ` [PATCH 2/2] mmc: sdhci-spear: " Jingoo Han
2013-03-29 7:18 ` Viresh Kumar
2013-04-04 14:14 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvz6pemg.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=jg1.han@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox