From: Yasushi SHOJI <yashi@atmark-techno.com>
To: linux-mmc@vger.kernel.org
Subject: mmc: tmio: why enable/disable SDIO irq on every transaction with IOMOD?
Date: Tue, 29 Nov 2016 15:23:47 +0900 [thread overview]
Message-ID: <87h96qkdn0.wl@dns1.atmark-techno.com> (raw)
Hello,
We've been using tmio_mmc_pio.c and seeing the following message:
"sh_mobile_sdhi sh_mobile_sdhi.1: timeout waiting for SD bus idle"
While searching for a fix, we found some code we don't understand.
I'm sending this question with a hope that someone would enlighten us a
bit. So, here goes.
The SDIO spec. seems to allow sending SDIO IRQ between the blocks of
multi-block transfer. The hardware, SCLKDIVEN bit of SD_INFO02, is
set to zero (0) and prohibits to access IOMOD bit of SDIO_MODE
register while multi-block transfer is going.
The current code, however, tries to disable SDIO IRQ by setting IOMOD
to zero in tmio_mmc_enable_sdio_irq() all the time, even during
multi-block transfer. This prints the above waring. What we don't
understand is that the code does both masking and disabling the IRQ.
So my question is that "What is the reason behind to disable IRQ with
SDIO_MODE? Is there any situation which masking with SDIO_INFO1_MASK
is not enough?
Thanks you,
--
yashi
next reply other threads:[~2016-11-29 6:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 6:23 Yasushi SHOJI [this message]
2016-11-29 8:52 ` mmc: tmio: why enable/disable SDIO irq on every transaction with IOMOD? Ulf Hansson
2016-12-01 10:46 ` Wolfram Sang
2016-12-01 12:46 ` Yasushi SHOJI
2016-12-01 14:49 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h96qkdn0.wl@dns1.atmark-techno.com \
--to=yashi@atmark-techno.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox