Re: [PATCH] mmc: core: reset sigal voltage on power up

[Chris Ball <cjb@laptop.org>]

Hi,

On Tue, Jul 17 2012, S, Venkatraman wrote:
> On Tue, Jul 10, 2012 at 2:25 PM, Aaron Lu <aaron.lu@amd.com> wrote:
>> Add a call to mmc_set_signal_voltage to set signal voltage to 3.3v in
>> mmc_power_up so that we do not need to touch signal voltage setting in
>> mmc/sd/sdio init functions and rescan function.
>>
>> For mmc/sd cards, when doing a suspend/resume cycle, consider the unsafe
>> resume case, the card will lose its power and when powered on again, we
>> will set signal voltage to 3.3v in mmc_power_up before its resume function
>> gets called, which will re-init the card.
>>
>> And for sdio cards, when doing a suspend/resume cycle, consider the unsafe
>> resume case, the card will either lose its power or not depending on if it
>> wants to wakeup the host. If power is not maintained, it is the same case as
>> mmc/sd cards. If power is maintained, mmc_power_up will not be called and
>> the card's signal voltage will remain at the last setting.
>>
>> Signed-off-by: Aaron Lu <aaron.lu@amd.com>
>
> Nice cleanup. I tested this patch on my OMAP board for MMC and SD,
> but not for SDIO..
> Tested-by: Venkatraman S <svenkatr@ti.com>

Thanks, pushed to mmc-next for 3.6.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child