From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH v2 1/2] mmc/host/rtsx: Configure SD_CFG2 register in sd_rw_multi Date: Mon, 19 Nov 2012 21:21:31 -0500 Message-ID: <87ip91f1zo.fsf@octavius.laptop.org> References: <00fb063304a0720f3ba9db6f79bb67263d450356.1353377266.git.wei_wang@realsil.com.cn> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from void.printf.net ([89.145.121.20]:59612 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753029Ab2KTCVo (ORCPT ); Mon, 19 Nov 2012 21:21:44 -0500 In-Reply-To: <00fb063304a0720f3ba9db6f79bb67263d450356.1353377266.git.wei_wang@realsil.com.cn> (wei wang's message of "Tue, 20 Nov 2012 10:09:16 +0800") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: wei_wang@realsil.com.cn Cc: sameo@linux.intel.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, gregkh@linuxfoundation.org, arnd@arndb.de, oakad@yahoo.com, bp@alien8.de Hi, Sorry to be pedantic, but: On Mon, Nov 19 2012, wei_wang@realsil.com.cn wrote: > For Realtek card reader, internal regsiter SD_CFG2 should be configured > before transferring data. In the prior version, the value of this register > has been calculated, but forgotten to write back to the internal register. With what consequences? Was the data transfer failing? Under which circumstances? Thanks, - Chris. -- Chris Ball One Laptop Per Child