From: Chris Ball <cjb@laptop.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-mmc@vger.kernel.org,
Prabu Thangamuthu <Prabu.T@synopsys.com>,
Seungwon Jeon <tgih.jun@samsung.com>
Subject: Re: [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR
Date: Sun, 25 Aug 2013 00:02:48 -0400 [thread overview]
Message-ID: <87k3jaquxj.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1375958698-10569-1-git-send-email-andriy.shevchenko@linux.intel.com> (Andy Shevchenko's message of "Thu, 8 Aug 2013 13:44:57 +0300")
Hi Andy,
On Thu, Aug 08 2013, Andy Shevchenko wrote:
> There is a typo when the mapped space is from BAR 2, but BAR 0 is used instead.
> This patch fixes the typo.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mmc/host/dw_mmc-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-pci.c
> index b456b0c..7d148d6 100644
> --- a/drivers/mmc/host/dw_mmc-pci.c
> +++ b/drivers/mmc/host/dw_mmc-pci.c
> @@ -59,7 +59,7 @@ static int dw_mci_pci_probe(struct pci_dev *pdev,
> if (ret)
> return ret;
>
> - host->regs = pcim_iomap_table(pdev)[0];
> + host->regs = pcim_iomap_table(pdev)[PCI_BAR_NO];
>
> ret = dw_mci_probe(host);
> if (ret)
Thanks, pushed to mmc-next for 3.12.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
prev parent reply other threads:[~2013-08-25 4:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 10:44 [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR Andy Shevchenko
2013-08-08 10:44 ` [PATCH 2/2] dw_mmc-pci: enable bus-mastering mode Andy Shevchenko
2013-08-12 7:34 ` Prabu Thangamuthu
2013-08-12 10:33 ` Seungwon Jeon
2013-08-12 7:34 ` [PATCH 1/2] dw_mmc-pci: get resources from a proper BAR Prabu Thangamuthu
2013-08-12 10:33 ` Seungwon Jeon
2013-08-25 4:02 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3jaquxj.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=Prabu.T@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox