From: Chris Ball <cjb@laptop.org>
To: Trey Ramsay <tramsay@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
Rich Rattanni <rattanni@gmail.com>,
Radovan Lekanovic <lekanovic@gmail.com>
Subject: Re: drivers/mmc/card/block.c infinite loop in mmc_blk_err_check waiting on R1_READY_FOR_DATA
Date: Wed, 31 Oct 2012 16:47:52 -0400 [thread overview]
Message-ID: <87k3u6id1j.fsf@octavius.laptop.org> (raw)
In-Reply-To: <50917DB7.6040503@linux.vnet.ibm.com> (Trey Ramsay's message of "Wed, 31 Oct 2012 14:36:23 -0500")
Hi,
On Wed, Oct 31 2012, Trey Ramsay wrote:
> In the 3.7-rc3 kernel, there is an infinite loop in the
> mmc_blk_err_check() function in drivers/mmc/card/block.c that can be
> caused bad hardware. This loop has moved around a little, but appears
> to have been around in the kernel since v2.6.12. The code will loop
> forever on write if the card isn't ready for data or if it's in
> program mode. I did some searching and saw that it was reported to
> linux-mmc@vger.kernel.org
> http://permalink.gmane.org/gmane.linux.kernel.mmc/2021 back in May but
> didn't see a response. Should there be a maximum retry count or a
> timeout to prevent an infinite loop?
Yes, a (long) timeout is a good idea, and there are three different
places where we use this type of loop waiting for R1_STATE_PRG to drop.
I'll add this to my TODO list, but feel free to fix it if you want to.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next parent reply other threads:[~2012-10-31 20:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50917DB7.6040503@linux.vnet.ibm.com>
2012-10-31 20:47 ` Chris Ball [this message]
[not found] ` <50A2A08D.5000601@linux.vnet.ibm.com>
2012-11-13 20:48 ` drivers/mmc/card/block.c infinite loop in mmc_blk_err_check waiting on R1_READY_FOR_DATA Chris Ball
2012-11-16 15:31 ` [PATCH 1/1] mmc: Bad device can cause mmc driver to hang Trey Ramsay
2012-11-16 15:37 ` Chris Ball
2012-11-16 23:52 ` Trey Ramsay
2012-11-17 0:37 ` Chris Ball
2012-11-17 5:16 ` Trey Ramsay
2012-11-17 0:40 ` Trey Ramsay
2012-11-17 14:34 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3u6id1j.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=lekanovic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rattanni@gmail.com \
--cc=tramsay@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox