From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH] mmc: pxamci: fix enum type confusion Date: Thu, 07 Mar 2019 20:15:39 +0100 Message-ID: <87mum65wdg.fsf@belgarion.home> References: <20190307100948.570006-1-arnd@arndb.de> <20190307152029.GD20201@archlinux-ryzen> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20190307152029.GD20201@archlinux-ryzen> (Nathan Chancellor's message of "Thu, 7 Mar 2019 08:20:29 -0700") Sender: linux-kernel-owner@vger.kernel.org To: Nathan Chancellor Cc: Arnd Bergmann , Ulf Hansson , Nick Desaulniers , Daniel Mack , Linus Walleij , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-mmc@vger.kernel.org Nathan Chancellor writes: > On Thu, Mar 07, 2019 at 11:09:19AM +0100, Arnd Bergmann wrote: >> clang points out several instances of mismatched types in this drivers, >> all coming from a single declaration: >> >> drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enum dma_transfer_direction' to >> different enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion] >> direction = DMA_DEV_TO_MEM; >> ~ ^~~~~~~~~~~~~~ >> drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enum dma_data_direction' to >> different enumeration type 'enum dma_transfer_direction' [-Werror,-Wenum-conversion] >> tx = dmaengine_prep_slave_sg(chan, data->sg, host->dma_len, direction, >> >> The behavior is correct, so this must be a simply typo from >> dma_data_direction and dma_transfer_direction being similarly named >> types with a similar purpose. >> >> Fixes: 6464b7140951 ("mmc: pxamci: switch over to dmaengine use") >> Signed-off-by: Arnd Bergmann > > Reviewed-by: Nathan Chancellor Acked-by: Robert Jarzmik Cheers. -- Robert