From: Chris Ball <cjb@laptop.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: sdhci: request irq after sdhci_init() is called
Date: Sat, 24 Aug 2013 22:11:46 -0400 [thread overview]
Message-ID: <87mwo6tt7h.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1373006335-31239-1-git-send-email-shawn.guo@linaro.org> (Shawn Guo's message of "Fri, 5 Jul 2013 14:38:55 +0800")
Hi Shawn,
On Fri, Jul 05 2013, Shawn Guo wrote:
> Generally request_irq() should be called after hardware has been
> initialized into a sane state. However, sdhci driver currently calls
> request_irq() before sdhci_init(). At least, the following kernel panic
> seen on i.MX6 is caused by that. The sdhci controller on i.MX6 may have
> noisy glitch on DAT1 line, which will trigger SDIO interrupt handling
> once request_irq() is called. But at this point, the SDIO interrupt
> handler host->sdio_irq_thread has not been registered yet. Thus, we
> see the NULL pointer access with wake_up_process(host->sdio_irq_thread)
> in mmc_signal_sdio_irq().
Thanks, pushed to mmc-next for 3.12.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
prev parent reply other threads:[~2013-08-25 2:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 6:38 [PATCH] mmc: sdhci: request irq after sdhci_init() is called Shawn Guo
2013-07-05 8:08 ` Lukasz Majewski
2013-08-19 8:33 ` Shawn Guo
2013-08-19 8:58 ` Russell King - ARM Linux
2013-08-25 2:11 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwo6tt7h.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox