Re: [PATCH 3/4] mmc: bfin_sdh: Remove redundent suspend and resume setting.

[Chris Ball <cjb@laptop.org>]

Hi,

On Mon, Aug 06 2012, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> mmc core suspend and resume functions had already called sdh_set_ios with proper flags.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> Signed-off-by: Bob Liu <lliubbo@gmail.com>
> ---
>  drivers/mmc/host/bfin_sdh.c |   15 ---------------
>  1 files changed, 0 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c
> index fa085a0..57b7548 100644
> --- a/drivers/mmc/host/bfin_sdh.c
> +++ b/drivers/mmc/host/bfin_sdh.c
> @@ -650,11 +650,6 @@ static int sdh_suspend(struct platform_device *dev, pm_message_t state)
>  	if (mmc)
>  		ret = mmc_suspend_host(mmc);
>  
> -#ifndef RSI_BLKSZ
> -	bfin_write_SDH_PWR_CTL(bfin_read_SDH_PWR_CTL() & ~PWR_ON);
> -#else
> -	bfin_write_SDH_CFG(bfin_read_SDH_CFG() & ~PWR_ON);
> -#endif
>  	peripheral_free_list(drv_data->pin_req);
>  
>  	return ret;
> @@ -676,16 +671,6 @@ static int sdh_resume(struct platform_device *dev)
>  	/* Secure Digital Host shares DMA with Nand controller */
>  	bfin_write_DMAC1_PERIMUX(bfin_read_DMAC1_PERIMUX() | 0x1);
>  #endif
> -#ifndef RSI_BLKSZ
> -	bfin_write_SDH_PWR_CTL(bfin_read_SDH_PWR_CTL() | PWR_ON);
> -	bfin_write_SDH_CFG(bfin_read_SDH_CFG() | CLKS_EN);
> -#else
> -	bfin_write_SDH_CFG(bfin_read_SDH_CFG() | CLKS_EN | PWR_ON);
> -#endif
> -	SSYNC();
> -
> -	bfin_write_SDH_CFG((bfin_read_SDH_CFG() & 0x1F) | (PUP_SDDAT | PUP_SDDAT3));
> -	SSYNC();
>  
>  	if (mmc)
>  		ret = mmc_resume_host(mmc);

Thanks, pushed to mmc-next for 3.7.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child