Re: [PATCH] mmc: pxamci: prepare and unprepare the clocks

[Robert Jarzmik <robert.jarzmik@free.fr>]

Ulf Hansson <ulf.hansson@linaro.org> writes:

> On 1 September 2014 15:28, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
>> Ulf Hansson <ulf.hansson@linaro.org> writes:
>>
>>> I understand your concern, but I don't see why there should be any
>>> major difference in clock management code (clk tree wise), due to this
>>> patch. It worked before, so likely it will work now!?
>>
>> It will ony work *differently*, it will change the clock management. It won't
>> break, but again it's *not* the purpose of the patch.  The patch is aimed at
>> removing a warning.
>
> Sorry if I was to vague, you must have misinterpreted my proposal. Let
> me try clarify how I think a patch should look like to solve the
> warning.
>
> 1) In pxamci_set_ios() replace " clk_enable()" with clk_prepare_enable().
> 2) In pxamci_set_ios() replace " clk_disable()" with clk_disable_unprepare().
>
> That should do the trick!
OK, I got it now, and yes, the clock flow will be the same.
I'm on my way to send v2 patch.

Cheers.

-- 
Robert