From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH] mmc: pxamci: prepare and unprepare the clocks Date: Tue, 02 Sep 2014 11:02:52 +0200 Message-ID: <87oauy4coz.fsf@free.fr> References: <1402343774-1072-1-git-send-email-robert.jarzmik@free.fr> <871trv5y6t.fsf@free.fr> <87sikb4gi5.fsf@free.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:49818 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbaIBJC5 (ORCPT ); Tue, 2 Sep 2014 05:02:57 -0400 In-Reply-To: (Ulf Hansson's message of "Tue, 2 Sep 2014 09:53:51 +0200") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson Cc: Chris Ball , linux-mmc Ulf Hansson writes: > On 1 September 2014 15:28, Robert Jarzmik wrote: >> Ulf Hansson writes: >> >>> I understand your concern, but I don't see why there should be any >>> major difference in clock management code (clk tree wise), due to this >>> patch. It worked before, so likely it will work now!? >> >> It will ony work *differently*, it will change the clock management. It won't >> break, but again it's *not* the purpose of the patch. The patch is aimed at >> removing a warning. > > Sorry if I was to vague, you must have misinterpreted my proposal. Let > me try clarify how I think a patch should look like to solve the > warning. > > 1) In pxamci_set_ios() replace " clk_enable()" with clk_prepare_enable(). > 2) In pxamci_set_ios() replace " clk_disable()" with clk_disable_unprepare(). > > That should do the trick! OK, I got it now, and yes, the clock flow will be the same. I'm on my way to send v2 patch. Cheers. -- Robert