* [PATCH 04/13] mmc: mxs-mmc: Let device core handle pinctrl
[not found] <1367863561-11534-1-git-send-email-fabio.estevam@freescale.com>
@ 2013-05-06 18:05 ` Fabio Estevam
2013-05-26 21:01 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2013-05-06 18:05 UTC (permalink / raw)
To: shawn.guo; +Cc: kernel, festevam, Fabio Estevam, Chris Ball, linux-mmc
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for handling pinctrl.
So remove devm_pinctrl_get_select_default() from the driver.
Cc: Chris Ball <cjb@laptop.org>
Cc: <linux-mmc@vger.kernel.org>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mmc/host/mxs-mmc.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
index 4efe302..2f64e5a 100644
--- a/drivers/mmc/host/mxs-mmc.c
+++ b/drivers/mmc/host/mxs-mmc.c
@@ -41,7 +41,6 @@
#include <linux/gpio.h>
#include <linux/regulator/consumer.h>
#include <linux/module.h>
-#include <linux/pinctrl/consumer.h>
#include <linux/stmp_device.h>
#include <linux/spi/mxs-spi.h>
@@ -592,7 +591,6 @@ static int mxs_mmc_probe(struct platform_device *pdev)
struct mxs_mmc_host *host;
struct mmc_host *mmc;
struct resource *iores, *dmares;
- struct pinctrl *pinctrl;
int ret = 0, irq_err, irq_dma;
dma_cap_mask_t mask;
struct regulator *reg_vmmc;
@@ -651,12 +649,6 @@ static int mxs_mmc_probe(struct platform_device *pdev)
}
}
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl)) {
- ret = PTR_ERR(pinctrl);
- goto out_mmc_free;
- }
-
ssp->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(ssp->clk)) {
ret = PTR_ERR(ssp->clk);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 04/13] mmc: mxs-mmc: Let device core handle pinctrl
2013-05-06 18:05 ` [PATCH 04/13] mmc: mxs-mmc: Let device core handle pinctrl Fabio Estevam
@ 2013-05-26 21:01 ` Fabio Estevam
2013-06-27 15:20 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2013-05-26 21:01 UTC (permalink / raw)
To: cjb, Fabio Estevam; +Cc: shawn.guo, kernel, linux-mmc
Hi Chris,
On Mon, May 6, 2013 at 3:05 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
> we can rely on device core for handling pinctrl.
>
> So remove devm_pinctrl_get_select_default() from the driver.
>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: <linux-mmc@vger.kernel.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Any comments on this one?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 04/13] mmc: mxs-mmc: Let device core handle pinctrl
2013-05-26 21:01 ` Fabio Estevam
@ 2013-06-27 15:20 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2013-06-27 15:20 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, shawn.guo, kernel, linux-mmc
Hi Fabio,
On Sun, May 26 2013, Fabio Estevam wrote:
> Hi Chris,
>
> On Mon, May 6, 2013 at 3:05 PM, Fabio Estevam
> <fabio.estevam@freescale.com> wrote:
>> Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
>> we can rely on device core for handling pinctrl.
>>
>> So remove devm_pinctrl_get_select_default() from the driver.
>>
>> Cc: Chris Ball <cjb@laptop.org>
>> Cc: <linux-mmc@vger.kernel.org>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Any comments on this one?
Thanks, pushed to mmc-next for 3.11.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-27 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1367863561-11534-1-git-send-email-fabio.estevam@freescale.com>
2013-05-06 18:05 ` [PATCH 04/13] mmc: mxs-mmc: Let device core handle pinctrl Fabio Estevam
2013-05-26 21:01 ` Fabio Estevam
2013-06-27 15:20 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox