Re: [PATCH] mmc: omap_hsmmc: set dto to 14 for all devices

[Chris Ball <cjb@laptop.org>]

Hi,

On Thu, Apr 05 2012, Tony Lindgren wrote:
> * Chris Ball <cjb@laptop.org> [120315 20:26]:
>> Hi Paul,
>> 
>> On Mon, Mar 12 2012, Paul Walmsley wrote:
>> > I don't think this is the right fix.  Steve Sakoman and I discussed this a 
>> > few months ago -- we did some debugging and Steve observed the timeouts on 
>> > multiple block writes (0x19):
>> > [...]
>> > So perhaps something like the following patch instead?  Unfortunately, I 
>> > don't have one of these crappy SD cards as far as I know, so I can't 
>> > really test it.
>> >
>> >
>> > - Paul
>> >
>> > From: Paul Walmsley <paul@pwsan.com>
>> > Date: Mon, 12 Mar 2012 04:46:29 -0600
>> > Subject: [PATCH] mmc: use really long write timeout to deal with crappy cards
>> >
>> > Several people have noticed that crappy SD cards take much longer to
>> > complete multiple block writes than the 300ms that Linux specifies.
>> > Try to work around this by using a three second write timeout instead.
>> >
>> > <insert Chase's patch description here>
>> >
>> > Not-yet-signed-off-by: Paul Walmsley <paul@pwsan.com>
>> 
>> Sounds like a good idea -- want to send a signed-off patch for this?
>
> This seems like the right fix to me too. Works on my pandaboard es and
> some random card that produces I/O errors without this.
>
> Tested-by: Tony Lindgren <tony@atomide.com>

Thanks.  Paul, just waiting for your Signed-off-by.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child