[PATCH] mmc: sdhci-pltfm: Fix timeout on t4240's sdhci controller

[PATCH] mmc: sdhci-pltfm: Fix timeout on t4240's sdhci controller

[Chunhe Lan]

This patch fixes timeout problems on t4240's sdhci controller:

	mmc0: Too large timeout requested for CMD25!
	mmc0: Too large timeout requested for CMD25!
	mmc0: Too large timeout requested for CMD25!

Signed-off-by: Chunhe Lan <Chunhe.Lan@freescale.com>
Cc: Chris Ball <cjb@laptop.org>
---
 drivers/mmc/host/sdhci-pltfm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index 3145a78..9db7b12 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -94,6 +94,7 @@ void sdhci_get_of_property(struct platform_device *pdev)
 
 		if (of_device_is_compatible(np, "fsl,p2020-esdhc") ||
 		    of_device_is_compatible(np, "fsl,p1010-esdhc") ||
+		    of_device_is_compatible(np, "fsl,t4240-esdhc") ||
 		    of_device_is_compatible(np, "fsl,mpc8536-esdhc"))
 			host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
 
-- 
1.7.6.5

Re: [PATCH] mmc: sdhci-pltfm: Fix timeout on t4240's sdhci controller

[Kevin Liu]

Hi,

> -----Original Message-----
> From: linux-mmc-owner@vger.kernel.org [mailto:linux-mmc-owner@vger.kernel.org] On Behalf Of Chunhe Lan
> Sent: Friday, March 08, 2013 4:14 PM
> To: linux-mmc@vger.kernel.org
> Cc: cjb@laptop.org; Chunhe Lan
> Subject: [PATCH] mmc: sdhci-pltfm: Fix timeout on t4240's sdhci controller
>
> This patch fixes timeout problems on t4240's sdhci controller:
>
>         mmc0: Too large timeout requested for CMD25!
>         mmc0: Too large timeout requested for CMD25!
>         mmc0: Too large timeout requested for CMD25!
>
> Signed-off-by: Chunhe Lan <Chunhe.Lan@freescale.com>
> Cc: Chris Ball <cjb@laptop.org>
> ---
>  drivers/mmc/host/sdhci-pltfm.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index 3145a78..9db7b12 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -94,6 +94,7 @@ void sdhci_get_of_property(struct platform_device *pdev)
>
>                 if (of_device_is_compatible(np, "fsl,p2020-esdhc") ||
>                     of_device_is_compatible(np, "fsl,p1010-esdhc") ||
> +                   of_device_is_compatible(np, "fsl,t4240-esdhc") ||
>                     of_device_is_compatible(np, "fsl,mpc8536-esdhc"))
>                         host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>

I think it's better to parse host specific property in host's driver
rather than the shared sdhci-pltfm.c.
Otherwise, sdhci_get_of_property will become bigger and bigger.
How do you think?
I have submitted below patch aim to do this:
[PATCH 2/2] mmc: sdhci-pltfm: add function in sdhci_ops to parse dt property

Thanks
Kevin

Re: [PATCH] mmc: sdhci-pltfm: Fix timeout on t4240's sdhci controller

[Chris Ball]

Hi,

On Fri, Mar 08 2013, Chunhe Lan wrote:
> This patch fixes timeout problems on t4240's sdhci controller:
>
> 	mmc0: Too large timeout requested for CMD25!
> 	mmc0: Too large timeout requested for CMD25!
> 	mmc0: Too large timeout requested for CMD25!
>
> Signed-off-by: Chunhe Lan <Chunhe.Lan@freescale.com>
> Cc: Chris Ball <cjb@laptop.org>
> ---
>  drivers/mmc/host/sdhci-pltfm.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index 3145a78..9db7b12 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -94,6 +94,7 @@ void sdhci_get_of_property(struct platform_device *pdev)
>  
>  		if (of_device_is_compatible(np, "fsl,p2020-esdhc") ||
>  		    of_device_is_compatible(np, "fsl,p1010-esdhc") ||
> +		    of_device_is_compatible(np, "fsl,t4240-esdhc") ||
>  		    of_device_is_compatible(np, "fsl,mpc8536-esdhc"))
>  			host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;

Thanks, pushed to mmc-next for 3.10.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child