From: Chris Ball <cjb@laptop.org>
To: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Cc: linux-mmc@vger.kernel.org, yunhong.jiang@intel.com,
sheng@linux.intel.com, mikechan@google.com,
xiaohui.xin@intel.com, jun.nakajima@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: host: use resource_size()
Date: Fri, 22 Mar 2013 12:53:36 -0400 [thread overview]
Message-ID: <87r4j7ml4f.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1363112486-2543-1-git-send-email-silviupopescu1990@gmail.com> (Silviu-Mihai Popescu's message of "Tue, 12 Mar 2013 20:21:26 +0200")
Hi,
On Tue, Mar 12 2013, Silviu-Mihai Popescu wrote:
> Use resource_size() instead of explicit calculation. This was found via
> make coccicheck.
>
> Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
> ---
> drivers/mmc/host/android-goldfish.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/android-goldfish.c b/drivers/mmc/host/android-goldfish.c
> index ef3aef0..7780c14 100644
> --- a/drivers/mmc/host/android-goldfish.c
> +++ b/drivers/mmc/host/android-goldfish.c
> @@ -476,7 +476,7 @@ static int goldfish_mmc_probe(struct platform_device *pdev)
> host->mmc = mmc;
>
> pr_err("mmc: Mapping %lX to %lX\n", (long)res->start, (long)res->end);
> - host->reg_base = ioremap(res->start, res->end - res->start + 1);
> + host->reg_base = ioremap(res->start, resource_size(res));
> if (host->reg_base == NULL) {
> ret = -ENOMEM;
> goto ioremap_failed;
Thanks, pushed to mmc-next for 3.10.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2013-03-22 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 18:21 [PATCH] mmc: host: use resource_size() Silviu-Mihai Popescu
2013-03-22 16:53 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4j7ml4f.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=jun.nakajima@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mikechan@google.com \
--cc=sheng@linux.intel.com \
--cc=silviupopescu1990@gmail.com \
--cc=xiaohui.xin@intel.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox