From: Chris Ball <cjb@laptop.org>
To: Konstantin Dorfman <kdorfman@codeaurora.org>
Cc: "Zhang, YiX X" <yix.x.zhang@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment
Date: Mon, 28 Jan 2013 15:56:09 -0500 [thread overview]
Message-ID: <87sj5l81sm.fsf@laptop.org> (raw)
In-Reply-To: <50EBD75F.7050805@codeaurora.org> (Konstantin Dorfman's message of "Tue, 08 Jan 2013 10:22:55 +0200")
Hi,
On Tue, Jan 08 2013, Konstantin Dorfman wrote:
> May be it is worth to change all this struct comments to be:
>
> u8 raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */
>
> This will reference actual offset value from "include/linux/mmc/mmc.h"
I think I prefer having the literal numbers accessible, even though it
duplicates data, so I've taken Zhang's original patch for now.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2013-01-28 20:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 6:07 [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment Zhang, YiX X
2013-01-08 8:22 ` Konstantin Dorfman
2013-01-08 10:14 ` Zhang, YiX X
2013-01-16 14:53 ` [PATCH v2] mmc: correct one comment error of structure mmc_ext_csd yix.x.zhang
2013-01-28 20:56 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj5l81sm.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=kdorfman@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=yix.x.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).