From: Chris Ball <cjb@laptop.org>
To: yongd <yongd@marvell.com>
Cc: linux-mmc@vger.kernel.org, prakity@marvell.com, ohad@wizery.com,
linus.walleij@linaro.org, ulf.hansson@stericsson.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mmc:sdio:guarantee setting card data bus width as 4-bit
Date: Thu, 17 May 2012 08:37:36 -0400 [thread overview]
Message-ID: <87sjez3rvz.fsf@laptop.org> (raw)
In-Reply-To: <1337058583-2014-1-git-send-email-yongd@marvell.com> (yongd@marvell.com's message of "Tue, 15 May 2012 13:09:43 +0800")
Hi,
On Tue, May 15 2012, yongd wrote:
> SDIO_CCCR_IF[1:0] in SDIO card is used for card data bus width
> setting as below,
> 00b: 1-bit bus
> 01b: Reserved
> 10b: 4-bit bus
> 11b: 8-bit bus(only for embedded SDIO)
> And sdio_enable_wide is for setting data bus width as 4-bit. But
> currently, it 1stly read the register, 2ndly OR' 1b with SDIO_CCCR_IF[1],
> and then write it back.
> As we can see, such way is based on such assumption that the
> SDIO_CCCR_IF[0] is always 0. Apparently, this is not right.
>
> Signed-off-by: yongd <yongd@marvell.com>
Thanks. Can we have your full name, for the copyright record?
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-05-17 12:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 5:09 [PATCH v2] mmc:sdio:guarantee setting card data bus width as 4-bit yongd
2012-05-15 5:11 ` Philip Rakity
2012-05-17 12:37 ` Chris Ball [this message]
2012-05-18 1:49 ` Yong Ding
2012-06-06 13:23 ` Chris Ball
2012-06-07 1:31 ` Yong Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjez3rvz.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=prakity@marvell.com \
--cc=ulf.hansson@stericsson.com \
--cc=yongd@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox