From: Chris Ball <cjb@laptop.org>
To: Will Newton <will.newton@gmail.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Will Newton <will.newton@imgtec.com>,
James Hogan <james.hogan@imgtec.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] dw-mmc: prevent the Null pointer dereference for dma_ops
Date: Wed, 18 Apr 2012 20:02:14 -0400 [thread overview]
Message-ID: <87sjg0lhbt.fsf@laptop.org> (raw)
In-Reply-To: <CAFbHwiQ5Q8qaog2ZPSs-HkoAnnGTofBFb4tM=XVo_vAYPkts2A@mail.gmail.com> (Will Newton's message of "Wed, 18 Apr 2012 11:02:11 +0100")
Hi,
On Wed, Apr 18 2012, Will Newton wrote:
> On Wed, Apr 18, 2012 at 7:42 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> Now, dma_ops is assumed that use the IDMAC.
>> But if dma_ops is assigned the pdata->dma_ops,
>> We didn't ensure that callback function is defined.
>>
>> If anything of callback didn't define, then should be run the PIO mode.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> drivers/mmc/host/dw_mmc.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> This looks ok.
>
> Acked-by: Will Newton <will.newton@imgtec.com>
Thanks, pushed to mmc-next for 3.5.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-04-19 0:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 6:42 [PATCH] dw-mmc: prevent the Null pointer dereference for dma_ops Jaehoon Chung
2012-04-18 10:02 ` Will Newton
2012-04-19 0:02 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjg0lhbt.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=james.hogan@imgtec.com \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=will.newton@gmail.com \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox