From: Eric Anholt <eric@anholt.net>
To: linux-rpi-kernel@lists.infradead.org
Cc: ulf.hansson@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, swarren@wwwdotorg.org,
lee@kernel.org, linux@armlinux.org.uk, catalin.marinas@arm.com,
will.deacon@arm.com, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Stefan Wahren <stefan.wahren@i2se.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v3 2/7] mmc: bcm2835: Add new driver for the sdhost controller.
Date: Wed, 01 Mar 2017 10:00:55 -0800 [thread overview]
Message-ID: <87tw7c27xk.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1487668026-7100-3-git-send-email-kraxel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]
Gerd Hoffmann <kraxel@redhat.com> writes:
> From: Eric Anholt <eric@anholt.net>
>
> The 2835 has two SD controllers: The Arasan sdhci controller (supported
> by the iproc driver) and a custom sdhost controller. This patch adds a
> driver for the latter.
>
> The sdhci controller supports both sdcard and sdio. The sdhost
> controller supports the sdcard only, but has better performance. Also
> note that the rpi3 has sdio wifi, so driving the sdcard with the sdhost
> controller allows to use the sdhci controller for wifi support.
>
> The configuration is done by devicetree via pin muxing. Both SD
> controller are available on the same pins (2 pin groups = pin 22 to 27 +
> pin 48 to 53). So it's possible to use both SD controllers at the same
> time with different pin groups.
>
> The code was originally written by Phil Elwell in the downstream
> Rasbperry Pi tree, and I did a major cleanup on it (+319, -707 lines
> out of the original 2055) for inclusion.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
Ulf, what do you need done to this driver patch before it can go in?
The commit message seems like it could use some rewriting at this point
(Personally I would drop the detailed changelogs from Stefan and Gerd,
updating the last paragraph here to give them credit), but what's
important to me is getting the driver in so that distros don't have to
carry this patch for wifi support.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-03-01 18:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 9:06 [PATCH v3 0/7] mmc: bcm2835: Add new driver for the sdhost controller Gerd Hoffmann
2017-02-21 9:07 ` [PATCH v3 1/7] dt-bindings: Add binding for brcm,bcm2835-sdhost Gerd Hoffmann
2017-02-21 9:07 ` [PATCH v3 2/7] mmc: bcm2835: Add new driver for the sdhost controller Gerd Hoffmann
2017-03-01 18:00 ` Eric Anholt [this message]
2017-03-01 19:21 ` Stefan Wahren
2017-03-01 19:31 ` Eric Anholt
2017-03-01 19:41 ` Stefan Wahren
2017-02-21 9:07 ` [PATCH v3 3/7] mmc: bcm2835: add sdhost controller to devicetree Gerd Hoffmann
[not found] ` <1487668026-7100-4-git-send-email-kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-02-21 15:57 ` Stefan Wahren
[not found] ` <1487668026-7100-1-git-send-email-kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-02-21 9:07 ` [PATCH v3 4/7] arm: set CONFIG_MMC_BCM2835=y in bcm2835_defconfig and multi_v7_defconfig Gerd Hoffmann
2017-02-21 9:07 ` [PATCH v3 5/7] arm64: set CONFIG_MMC_BCM2835=y in defconfig Gerd Hoffmann
2017-02-21 9:07 ` [PATCH v3 6/7] ARM: dts: bcm283x: switch from &sdhci to &sdhost Gerd Hoffmann
2017-02-21 9:07 ` [PATCH v3 7/7] ARM: dts: bcm2837: add &sdhci and &sdhost Gerd Hoffmann
2017-02-21 9:25 ` Baruch Siach
2017-03-14 14:22 ` [PATCH v3 0/7] mmc: bcm2835: Add new driver for the sdhost controller Peter Robinson
[not found] ` <CALeDE9Oaqe_7spH9r5-Bth9AvrwviFsZ4woEyE_Zyrws0jM9Dw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-15 8:21 ` Gerd Hoffmann
2017-03-15 10:06 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw7c27xk.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kraxel@redhat.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
--cc=swarren@wwwdotorg.org \
--cc=ulf.hansson@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox