From: Chris Ball <cjb@laptop.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-mmc@vger.kernel.org, 'Ben Dooks' <ben-linux@fluff.org>
Subject: Re: [PATCH] mmc: sdhci-s3c: fix checkpatch error and warnings
Date: Wed, 29 Aug 2012 06:36:18 -0400 [thread overview]
Message-ID: <87txvmugrh.fsf@octavius.laptop.org> (raw)
In-Reply-To: <002701cd85a8$0c35e130$24a1a390$%han@samsung.com> (Jingoo Han's message of "Wed, 29 Aug 2012 14:35:06 +0900")
Hi,
On Wed, Aug 29 2012, Jingoo Han wrote:
> This patch fixes the checkpatch error and warnings listed below:
>
> ERROR: return is not a function, parentheses are not required
> WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
> WARNING: quoted string split across lines
> WARNING: line over 80 characters
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Thanks, pushed to mmc-next for 3.7 with Jaehoon's ACK.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-08-29 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 5:35 [PATCH] mmc: sdhci-s3c: fix checkpatch error and warnings Jingoo Han
2012-08-29 6:22 ` Jaehoon Chung
2012-08-29 10:36 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txvmugrh.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=ben-linux@fluff.org \
--cc=jg1.han@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox