From: Chris Ball <cjb@laptop.org>
To: Aaron Lu <aaron.lu@amd.com>
Cc: linux-mmc@vger.kernel.org, Aaron Lu <aaron.lwe@gmail.com>
Subject: Re: [PATCH v2 2/2] mmc: sdhci: A new flag SDHCI_NEEDS_RETUNING_TIMER
Date: Tue, 03 Jul 2012 20:46:34 -0400 [thread overview]
Message-ID: <87vci45p5h.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1340957852-28936-3-git-send-email-aaron.lu@amd.com> (Aaron Lu's message of "Fri, 29 Jun 2012 16:17:32 +0800")
Hi,
On Fri, Jun 29 2012, Aaron Lu wrote:
> Add a new flag of SDHCI_NEEDS_RETUNING_TIMER to represent if the host
> currently needs retuning timer when driving the card inserted.
Minor changes:
Could we call it "SDHCI_USING_RETUNING_TIMER", then? I don't think
NEEDS makes the use clear enough.
> @@ -1889,10 +1891,9 @@ out:
> * try tuning again at a later time, when the re-tuning timer expires.
> * So for these controllers, we return 0. Since there might be other
> * controllers who do not have this capability, we return error for
> - * them.
> + * them. SDHCI_NEEDS_RETUNING_TIMER means the host supports re-tuning.
This comment seems wrong, or at least incomplete. You've just described
in the commit message how the flag's not about whether the host supports
it, but is instead about whether it's currently in use by the card.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-07-04 0:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 8:17 [PATCH v2 0/2] Fixes for tuning stuffs Aaron Lu
2012-06-29 8:17 ` [PATCH v2 1/2] mmc: sdhci: restore host settings when card is removed Aaron Lu
2012-07-04 0:40 ` Chris Ball
2012-06-29 8:17 ` [PATCH v2 2/2] mmc: sdhci: A new flag SDHCI_NEEDS_RETUNING_TIMER Aaron Lu
2012-07-04 0:46 ` Chris Ball [this message]
2012-07-04 5:29 ` [PATCH v3 2/2] mmc: sdhci: A new flag SDHCI_USING_RETUNING_TIMER Aaron Lu
2012-07-04 7:14 ` Girish K S
2012-07-09 5:10 ` Philip Rakity
2012-07-10 2:55 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vci45p5h.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=aaron.lu@amd.com \
--cc=aaron.lwe@gmail.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox