From: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Gustavo Padovan <gustavo.padovan@collabora.com>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Subject: Re: [PATCH v2 RESEND] sdhci: Ignore unexpected CARD_INT interrupts
Date: Fri, 27 Jan 2017 17:20:20 -0200 [thread overview]
Message-ID: <87wpdg9uob.fsf@dilma.collabora.co.uk> (raw)
In-Reply-To: <CAPDyKFpowPmbwvHL9NL60zAABfW53sDKkp0Ag5aXs4jZZLC=Dg@mail.gmail.com> (Ulf Hansson's message of "Thu, 19 Jan 2017 21:37:30 +0100")
Ulf Hansson <ulf.hansson@linaro.org> writes:
> On 16 January 2017 at 15:23, Gabriel Krisman Bertazi
> <krisman@collabora.co.uk> wrote:
>> One of our kernelCI boxes hanged at boot because a faulty eSDHC device
>> was triggering spurious CARD_INT interrupts for SD cards, causing CMD52
>> reads, which are not allowed for SD devices. This adds a sanity check
>> to the interruption path, preventing that illegal command from getting
>> sent if the CARD_INT interruption should be disabled.
>>
>> This quirk allows that particular machine to resume boot despite the
>> faulty hardware, instead of getting hung dealing with thousands of
>> mishandled interrupts.
>>
>> Suggested-by: Adrian Hunter <adrian.hunter@intel.com>
>> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
>> CC: Ulf Hansson <ulf.hansson@linaro.org>
>> CC: linux-mmc@vger.kernel.org
>
> Thanks, applied for next with update commit msg header and by removing
> the CCs from the changelog.
Hi Ulf,
Thanks for applying. Although, I saw it got queued to the next merge
window, but I we believe it to be -rc material, since it fixes a hang
in our kernelCI boxes[1], and is preventing us from testing other features
in this box. Can you consider submitting it to Linus for the next -rc?
it will be much appreciated!
[1] <https://kernelci.org/boot/id/5881c81859b5140b59f6c3ae/>
Thanks.
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2017-01-27 19:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 14:23 [PATCH v2 RESEND] sdhci: Ignore unexpected CARD_INT interrupts Gabriel Krisman Bertazi
2017-01-19 10:28 ` Adrian Hunter
2017-01-19 20:37 ` Ulf Hansson
2017-01-27 19:20 ` Gabriel Krisman Bertazi [this message]
2017-01-30 8:19 ` Ulf Hansson
2017-01-30 12:34 ` Gabriel Krisman Bertazi
2017-01-30 12:40 ` Adrian Hunter
2017-01-30 13:40 ` Gabriel Krisman Bertazi
2017-01-31 10:35 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpdg9uob.fsf@dilma.collabora.co.uk \
--to=krisman@collabora.co.uk \
--cc=adrian.hunter@intel.com \
--cc=gustavo.padovan@collabora.com \
--cc=linux-mmc@vger.kernel.org \
--cc=sjoerd.simons@collabora.co.uk \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox