public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Yasushi SHOJI <yashi@atmark-techno.com>
To: wsa+renesas@sang-engineering.com
Cc: linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [RFC] mmc: tmio: use SDIO master interrupt bit only when allowed
Date: Fri, 02 Dec 2016 14:57:08 +0900	[thread overview]
Message-ID: <87wpfivpor.wl@dns1.atmark-techno.com> (raw)
In-Reply-To: <20161201150813.13058-1-wsa+renesas@sang-engineering.com>

On Fri, 02 Dec 2016 00:08:13 +0900,
Wolfram Sang wrote:
> 
> The master bit to enable SDIO interrupts can only be accessed if
> SCLKDIVEN bit allows that. However, the core uses the SDIO enable
> callback at times when SCLKDIVEN forbids the change. This leads to
> "timeout waiting for SD bus idle" messages.
> 
> We now activate the master bit in probe once if SDIO is supported. IRQ
> en-/disabling will be done now by the individual IRQ enablement bits
> only.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> 
> Compile tested only, due to no testcase.

We've reviewed and tested your patch.  It looks good and works fine
under the condition we had.

Reviewed-by: Yasushi SHOJI <yashi@atmark-techno.com>

Cc: stable@vger.kernel.org if other boards with the same controller
can confirm.

Thanks you Wolfram for your quick response and the rfc.
-- 
           yashi

      reply	other threads:[~2016-12-02  5:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01 15:08 [RFC] mmc: tmio: use SDIO master interrupt bit only when allowed Wolfram Sang
2016-12-02  5:57 ` Yasushi SHOJI [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpfivpor.wl@dns1.atmark-techno.com \
    --to=yashi@atmark-techno.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox