From: Chris Ball <cjb@laptop.org>
To: Will Newton <will.newton@gmail.com>
Cc: Kyoungil Kim <ki0351.kim@samsung.com>,
linux-mmc@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [PATCH] mmc: dw_mmc: Fixed sdio interrupt mask bit setting bug
Date: Thu, 17 May 2012 08:35:38 -0400 [thread overview]
Message-ID: <87wr4b3rz9.fsf@laptop.org> (raw)
In-Reply-To: <CAFbHwiSwu32cdzQib+TYj9uSt+PXmA1Ltk1mzECRoy1DfdjyNQ@mail.gmail.com> (Will Newton's message of "Mon, 14 May 2012 10:06:41 +0100")
Hi,
On Mon, May 14 2012, Will Newton wrote:
> On Mon, May 14, 2012 at 9:38 AM, Kyoungil Kim <ki0351.kim@samsung.com> wrote:
>> The sdio interrupt mask bits are arranged in [31:16].
>> (1 << SDMMC_INT_SDIO(slot->id))) does 16 bits left shift twice.
>> So this patch changes to do 16 bits left shift only one time.
>>
>> Signed-off-by: Kyoungil Kim <ki0351.kim@samsung.com>
>> ---
>> drivers/mmc/host/dw_mmc.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> Yes, looks correct.
>
> Acked-by: Will Newton <will.newton@imgtec.com>
Thanks, pushed to mmc-next for 3.5.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-05-17 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 8:38 [PATCH] mmc: dw_mmc: Fixed sdio interrupt mask bit setting bug Kyoungil Kim
2012-05-14 8:54 ` Shashidhar Hiremath
2012-05-14 9:06 ` Will Newton
2012-05-17 12:35 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wr4b3rz9.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=kgene.kim@samsung.com \
--cc=ki0351.kim@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox