* [PATCH] mmc: dw_mmc: Fixed sdio interrupt mask bit setting bug
@ 2012-05-14 8:38 Kyoungil Kim
2012-05-14 8:54 ` Shashidhar Hiremath
2012-05-14 9:06 ` Will Newton
0 siblings, 2 replies; 4+ messages in thread
From: Kyoungil Kim @ 2012-05-14 8:38 UTC (permalink / raw)
To: linux-mmc, linux-samsung-soc
Cc: 'Chris Ball', 'Kyoungil Kim',
'Kukjin Kim'
The sdio interrupt mask bits are arranged in [31:16].
(1 << SDMMC_INT_SDIO(slot->id))) does 16 bits left shift twice.
So this patch changes to do 16 bits left shift only one time.
Signed-off-by: Kyoungil Kim <ki0351.kim@samsung.com>
---
drivers/mmc/host/dw_mmc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 1532357..9bbf45f 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -857,10 +857,10 @@ static void dw_mci_enable_sdio_irq(struct mmc_host *mmc, int enb)
int_mask = mci_readl(host, INTMASK);
if (enb) {
mci_writel(host, INTMASK,
- (int_mask | (1 << SDMMC_INT_SDIO(slot->id))));
+ (int_mask | SDMMC_INT_SDIO(slot->id)));
} else {
mci_writel(host, INTMASK,
- (int_mask & ~(1 << SDMMC_INT_SDIO(slot->id))));
+ (int_mask & ~SDMMC_INT_SDIO(slot->id)));
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: dw_mmc: Fixed sdio interrupt mask bit setting bug
2012-05-14 8:38 [PATCH] mmc: dw_mmc: Fixed sdio interrupt mask bit setting bug Kyoungil Kim
@ 2012-05-14 8:54 ` Shashidhar Hiremath
2012-05-14 9:06 ` Will Newton
1 sibling, 0 replies; 4+ messages in thread
From: Shashidhar Hiremath @ 2012-05-14 8:54 UTC (permalink / raw)
To: Kyoungil Kim; +Cc: linux-mmc, linux-samsung-soc, Chris Ball, Kukjin Kim
I agree with you, looks like a bug that got introduced with SDIO support.
acked-by Shashidhar Hiremath <shashidharh@vayavyalabs.com>
On Mon, May 14, 2012 at 2:08 PM, Kyoungil Kim <ki0351.kim@samsung.com> wrote:
> The sdio interrupt mask bits are arranged in [31:16].
> (1 << SDMMC_INT_SDIO(slot->id))) does 16 bits left shift twice.
> So this patch changes to do 16 bits left shift only one time.
>
> Signed-off-by: Kyoungil Kim <ki0351.kim@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 1532357..9bbf45f 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -857,10 +857,10 @@ static void dw_mci_enable_sdio_irq(struct mmc_host *mmc, int enb)
> int_mask = mci_readl(host, INTMASK);
> if (enb) {
> mci_writel(host, INTMASK,
> - (int_mask | (1 << SDMMC_INT_SDIO(slot->id))));
> + (int_mask | SDMMC_INT_SDIO(slot->id)));
> } else {
> mci_writel(host, INTMASK,
> - (int_mask & ~(1 << SDMMC_INT_SDIO(slot->id))));
> + (int_mask & ~SDMMC_INT_SDIO(slot->id)));
> }
> }
>
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
cheers,
Shashidhar Hiremath
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: dw_mmc: Fixed sdio interrupt mask bit setting bug
2012-05-14 8:38 [PATCH] mmc: dw_mmc: Fixed sdio interrupt mask bit setting bug Kyoungil Kim
2012-05-14 8:54 ` Shashidhar Hiremath
@ 2012-05-14 9:06 ` Will Newton
2012-05-17 12:35 ` Chris Ball
1 sibling, 1 reply; 4+ messages in thread
From: Will Newton @ 2012-05-14 9:06 UTC (permalink / raw)
To: Kyoungil Kim; +Cc: linux-mmc, linux-samsung-soc, Chris Ball, Kukjin Kim
On Mon, May 14, 2012 at 9:38 AM, Kyoungil Kim <ki0351.kim@samsung.com> wrote:
> The sdio interrupt mask bits are arranged in [31:16].
> (1 << SDMMC_INT_SDIO(slot->id))) does 16 bits left shift twice.
> So this patch changes to do 16 bits left shift only one time.
>
> Signed-off-by: Kyoungil Kim <ki0351.kim@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Yes, looks correct.
Acked-by: Will Newton <will.newton@imgtec.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: dw_mmc: Fixed sdio interrupt mask bit setting bug
2012-05-14 9:06 ` Will Newton
@ 2012-05-17 12:35 ` Chris Ball
0 siblings, 0 replies; 4+ messages in thread
From: Chris Ball @ 2012-05-17 12:35 UTC (permalink / raw)
To: Will Newton; +Cc: Kyoungil Kim, linux-mmc, linux-samsung-soc, Kukjin Kim
Hi,
On Mon, May 14 2012, Will Newton wrote:
> On Mon, May 14, 2012 at 9:38 AM, Kyoungil Kim <ki0351.kim@samsung.com> wrote:
>> The sdio interrupt mask bits are arranged in [31:16].
>> (1 << SDMMC_INT_SDIO(slot->id))) does 16 bits left shift twice.
>> So this patch changes to do 16 bits left shift only one time.
>>
>> Signed-off-by: Kyoungil Kim <ki0351.kim@samsung.com>
>> ---
>> drivers/mmc/host/dw_mmc.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> Yes, looks correct.
>
> Acked-by: Will Newton <will.newton@imgtec.com>
Thanks, pushed to mmc-next for 3.5.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-17 12:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-14 8:38 [PATCH] mmc: dw_mmc: Fixed sdio interrupt mask bit setting bug Kyoungil Kim
2012-05-14 8:54 ` Shashidhar Hiremath
2012-05-14 9:06 ` Will Newton
2012-05-17 12:35 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox