From: Chris Ball <cjb@laptop.org>
To: "Eric Bénard" <eric@eukrea.com>
Cc: linux-mmc@vger.kernel.org, shawn.guo@linaro.org,
w.sang@pengutronix.de, s.hauer@pengutronix.de
Subject: Re: [PATCH] mmc: unbreak sdhci-esdhc-imx on i.MX25
Date: Wed, 18 Apr 2012 20:00:42 -0400 [thread overview]
Message-ID: <87wr5clhed.fsf@laptop.org> (raw)
In-Reply-To: <1334709020-31088-1-git-send-email-eric@eukrea.com> ("Eric Bénard"'s message of "Wed, 18 Apr 2012 02:30:20 +0200")
Hi,
On Tue, Apr 17 2012, Eric Bénard wrote:
> this was broken by me in 37865fe91582582a6f6c00652f6a2b1ff71f8a78
> "mmc: sdhci-esdhc-imx: fix timeout on i.MX's sdhc" where more
> extensive tests would have shown that read or write of data
> to the card were failing (even if the partition table was
> correctly read).
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> Acked-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 6193a0d..8abdaf6 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -467,8 +467,7 @@ static int __devinit sdhci_esdhc_imx_probe(struct platform_device *pdev)
> clk_prepare_enable(clk);
> pltfm_host->clk = clk;
>
> - if (!is_imx25_esdhc(imx_data))
> - host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
> + host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>
> if (is_imx25_esdhc(imx_data) || is_imx35_esdhc(imx_data))
> /* Fix errata ENGcm07207 present on i.MX25 and i.MX35 */
Thanks, pushed to mmc-next for 3.4.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-04-19 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 0:30 [PATCH] mmc: unbreak sdhci-esdhc-imx on i.MX25 Eric Bénard
2012-04-19 0:00 ` Chris Ball [this message]
2012-04-19 0:05 ` Wolfram Sang
2012-04-19 0:12 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wr5clhed.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=eric@eukrea.com \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox