From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] mmc: dw_mmc: fix dw_mci_get_cd Date: Thu, 16 Jan 2014 10:29:40 -0800 Message-ID: <87y52fok4r.fsf@linaro.org> References: <1389839502-13046-1-git-send-email-zhangfei.gao@linaro.org> <1389876527-13498-1-git-send-email-zhangfei.gao@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-pb0-f51.google.com ([209.85.160.51]:43113 "EHLO mail-pb0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751832AbaAPS3p (ORCPT ); Thu, 16 Jan 2014 13:29:45 -0500 Received: by mail-pb0-f51.google.com with SMTP id rp16so2996867pbb.24 for ; Thu, 16 Jan 2014 10:29:43 -0800 (PST) In-Reply-To: <1389876527-13498-1-git-send-email-zhangfei.gao@linaro.org> (Zhangfei Gao's message of "Thu, 16 Jan 2014 20:48:47 +0800") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Zhangfei Gao Cc: Russell King - ARM Linux , Sachin Kamat , Chris Ball , Arnd Bergmann , Mike Turquette , Jaehoon Chung , Seungwon Jeon , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@linaro.org Zhangfei Gao writes: > Introduced from commit bf626e5550f24aec24975a0e85ad8e572ca76a6b > CDETECT is ignored since negated return value of mmc_gpio_get_cd(mmc) > can not be checked by IS_ERR_VALUE. > Add spin_lock_bh(&host->lock) for atomic accessing DW_MMC_CARD_PRESENT, > otherwise sd detect may occasionally fail. > > Signed-off-by: Zhangfei Gao > Reported-by: Kevin Hilman > Reviewed-by: Sachin Kamat > Tested-by: Sachin Kamat I didn't look at the patch in detail, but can at least confirm that Arndale boots again in -next with this patch applied. Tested-by: Kevin Hilman Kevin