Re: [PATCH v3] mmc: core: Fix the HPI execution sequence

[Chris Ball <cjb@laptop.org>]

Hi, trivial style comments,

On Wed, Jun 20 2012, Venkatraman S wrote:
>	switch (R1_CURRENT_STATE(status)) {
>

No newline here.

>	case R1_STATE_IDLE:
>	case R1_STATE_READY:
>	case R1_STATE_STBY: /* intentional fall through */
>		/* In idle states, HPI is not needed and the caller
>		 can issue the next intended command immediately */
>		goto out;
>		break;

This might just be personal style, but I don't think of this as
"intentional fall through" -- you're just matching multiple cases.

Case fall-through would be if the code inside the cases didn't call
goto or break at the end and kept going into the next code block,
which doesn't happen here.  Here's an elegant use of fall-through:
   http://chris.printf.net/btrfs_parse_size.txt

I don't think you should bother using break after you've already
called goto.

Also, please use:
/*
 * comment 1
 * comment 2
 */

for multiline comments instead of

/* comment 1
 comment 2 */
 
Thanks!

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child