From: Chris Ball <cjb@laptop.org>
To: "S, Venkatraman" <svenkatr@ti.com>
Cc: Ming Lei <ming.lei@canonical.com>,
Grant Likely <grant.likely@secretlab.ca>,
linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH -next] mmc: omap_hsmmc: pass IRQF_ONESHOT to request_threaded_irq
Date: Thu, 17 May 2012 10:32:37 -0400 [thread overview]
Message-ID: <87y5oq3mka.fsf@laptop.org> (raw)
In-Reply-To: <CANfBPZ__JCHs01yt_AwgqjVXebBCxMiqCyThPf4Rr8MB191h5g@mail.gmail.com> (Venkatraman S.'s message of "Thu, 17 May 2012 19:26:38 +0530")
Hi,
On Thu, May 17 2012, S, Venkatraman wrote:
> On Thu, May 17, 2012 at 7:57 AM, Ming Lei <ming.lei@canonical.com> wrote:
>> The flag of IRQF_ONESHOT should be passed to request_threaded_irq,
>> otherwise the following failure message should be dumped because
>> hardware handler is defined as NULL:
>>
>> [ 3.383483] genirq: Threaded irq requested with handler=NULL and
>> !ONESHOT for irq 368
>> [ 3.392730] omap_hsmmc: probe of omap_hsmmc.0 failed with error -22
>>
>> The patch fixes one kernel hang bug which is caused by mmc card
>> probe failure and root device can't be brought up.
>>
>> Signed-off-by: Ming Lei <ming.lei@canonical.com>
>
> Right thing to do!
> Acked-by: Venkatraman S <svenkatr@ti.com>
Thanks, pushed to mmc-next for 3.5 with a stable@ tag added.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-05-17 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 2:27 [PATCH -next] mmc: omap_hsmmc: pass IRQF_ONESHOT to request_threaded_irq Ming Lei
2012-05-17 13:56 ` S, Venkatraman
2012-05-17 14:32 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5oq3mka.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=svenkatr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox