From: Chris Ball <cjb@laptop.org>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: spear-devel <spear-devel@list.st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>, "sr@denx.de" <sr@denx.de>
Subject: Re: [PATCH 1/3] mmc/sdhci-spear: No need to check 'pdev == NULL' in probe
Date: Tue, 01 May 2012 10:33:09 -0400 [thread overview]
Message-ID: <87y5pchsyi.fsf@laptop.org> (raw)
In-Reply-To: <4F9FA372.3060807@st.com> (Viresh Kumar's message of "Tue, 1 May 2012 14:18:50 +0530")
Hi Viresh,
On Tue, May 01 2012, Viresh Kumar wrote:
> On 4/10/2012 3:06 PM, Viresh KUMAR wrote:
>> On 3/27/2012 8:40 AM, Viresh KUMAR wrote:
>>> > pdev is guaranteed to be valid in probe. And so check is not required to check
>>> > if it is non-NULL. Remove it.
>>> >
>>> > Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
>> Hi Chris,
>>
>> Can you atleast apply first two patches of this set. Will rework patch 3/3 after
>> DT support is finalized by arnd.
>
> Chris,
>
> Can you please apply these?
Sorry for the delay -- I've pushed patches 1 and 2 to mmc-next for 3.5 now.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-05-01 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 3:10 [PATCH 1/3] mmc/sdhci-spear: No need to check 'pdev == NULL' in probe Viresh Kumar
2012-03-27 3:10 ` [PATCH 2/3] mmc/sdhci-spear: Use devm_* derivatives Viresh Kumar
2012-03-27 3:10 ` [PATCH 3/3] mmc: sdhci-spear: add device tree bindings Viresh Kumar
2012-04-10 9:36 ` [PATCH 1/3] mmc/sdhci-spear: No need to check 'pdev == NULL' in probe Viresh Kumar
2012-05-01 8:48 ` Viresh Kumar
2012-05-01 14:33 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5pchsyi.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-mmc@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=sr@denx.de \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).