Re: [PATCH] mmc: core: Prevent eMMC VCC supply to be cut from late init

[Chris Ball <cjb@laptop.org>]

Hi,

On Wed, May 09 2012, Mark Brown wrote:
> On Wed, May 09, 2012 at 04:15:26PM +0200, Ulf Hansson wrote:
>> From: Ulf Hansson <ulf.hansson@linaro.org>
>> 
>> For eMMC cards that has been initialized from a bootloader,
>> the VCC voltage supply must not be cut in an uncontrolled
>> manner, without first sending SLEEP or POWEROFF_NOTIFY.
>> 
>> The regulator_init_complete late initcall, may cut the VCC
>> regulator if it's reference counter is zero. To be able to
>> prevent the regulator from being cut, mmc_start_host, which
>> should execute at device init and thus before late init,
>> calls mmc_power_up. Then the host driver is able to increase
>> the reference to the regulator.
>
> This looks like a good, simple solution - working out how we avoid extra
> power ups will probably be more invasive and might not be worth the
> effort for something that's boot time only.
>
> Reviwed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Thanks, pushed to mmc-next for 3.5.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child