From: Krzysztof Kozlowski <krzk@kernel.org>
To: "ping.gao" <ping.gao@samsung.com>,
shawn.lin@rock-chips.com, ulf.hansson@linaro.org,
jh80.chung@samsung.com, sebastian.reichel@collabora.com
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
hy50.seo@samsung.com, kwangwon.min@samsung.com
Subject: Re: [PATCH v2 3/3] dt-bindings: mmc: synopsys-dw-mshc: clk is not a must of two
Date: Fri, 13 Feb 2026 08:37:08 +0100 [thread overview]
Message-ID: <8a3be8ef-854e-4242-aa63-d10c1649bc9f@kernel.org> (raw)
In-Reply-To: <20260213030905.1134519-1-ping.gao@samsung.com>
On 13/02/2026 04:09, ping.gao wrote:
> mmc biu and ciu clk don't have to be set
This makes no sense, you changed nothing.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830
>
> Signed-off-by: ping.gao <ping.gao@samsung.com>
Use real name.
> ---
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-13 7:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260123085150epcas5p42f2cc04843ae7657380b2968261246cb@epcas5p4.samsung.com>
2026-01-23 8:56 ` [PATCH] drivers: dw_mmc: Replace devm_clk_get with devm_clk_get_optional ping.gao
2026-01-23 9:46 ` Ulf Hansson
2026-02-11 9:56 ` Shawn Lin
2026-02-11 8:18 ` ping.gao
2026-02-12 10:36 ` ping.gao
2026-02-12 10:45 ` Shawn Lin
2026-02-13 3:08 ` [PATCH v2 1/3] mmc: dw_mmc: Using devm_clk_get_optional() for biu_clk ping.gao
2026-02-13 3:24 ` Shawn Lin
2026-02-13 3:08 ` [PATCH v2 2/3] mmc: dw_mmc-k3: before set biu_clk rate, check biu_clk available or not ping.gao
2026-02-13 3:30 ` Shawn Lin
2026-02-13 3:09 ` [PATCH v2 3/3] dt-bindings: mmc: synopsys-dw-mshc: clk is not a must of two ping.gao
2026-02-13 3:14 ` Shawn Lin
2026-02-13 7:37 ` Krzysztof Kozlowski [this message]
2026-02-13 5:34 ` [PATCH v3 1/3] dt-bindings: mmc: synopsys-dw-mshc: No need to enforce setting two clocks ping.gao
2026-02-13 7:37 ` Krzysztof Kozlowski
2026-02-13 5:34 ` [PATCH v3 2/3] mmc: dw_mmc-k3: before set biu_clk rate, check biu_clk available or not ping.gao
2026-02-13 5:34 ` [PATCH v3 3/3] mmc: dw_mmc: Using devm_clk_get_optional() for biu_clk ping.gao
2026-02-26 9:09 ` [PATCH v3 1/3] mmc: dw_mmc-k3: before set biu_clk rate, check biu_clk available or not ping.gao
2026-02-26 9:10 ` [PATCH v3 2/3] mmc: dw_mmc: Using devm_clk_get_optional() for biu_clk ping.gao
2026-02-26 9:10 ` [PATCH v3 3/3] dt-bindings: mmc: synopsys-dw-mshc: No need to enforce setting two clocks ping.gao
2026-02-27 7:50 ` Krzysztof Kozlowski
2026-02-27 7:52 ` Krzysztof Kozlowski
2026-02-27 7:51 ` Krzysztof Kozlowski
2026-02-27 7:53 ` Krzysztof Kozlowski
2026-02-28 3:13 ` ping.gao
2026-02-28 9:46 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a3be8ef-854e-4242-aa63-d10c1649bc9f@kernel.org \
--to=krzk@kernel.org \
--cc=hy50.seo@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=kwangwon.min@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ping.gao@samsung.com \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox