Re: [PATCH 2/9] mmc: meson-gx: minor improvements in meson_mmc_set_ios

[Heiner Kallweit <hkallweit1@gmail.com>]

Am 01.02.2017 um 12:55 schrieb Jaehoon Chung:
> On 02/01/2017 05:57 AM, Heiner Kallweit wrote:
>> val isn't used in the switch clause and afterwards there's an
>> identical statement. So remove it.
>>
>> In case of an unexpected bus width the error message indicates
>> the intention to set the bus width to 4 and to go on.
>> So remove the return statement. This return statement also
>> conflicts with "setting to 4" because nothing would be set
>> actually before returning.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>>  drivers/mmc/host/meson-gx-mmc.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>> index da3cce31..38edc60d 100644
>> --- a/drivers/mmc/host/meson-gx-mmc.c
>> +++ b/drivers/mmc/host/meson-gx-mmc.c
>> @@ -379,7 +379,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>>  	meson_mmc_clk_set(host, ios->clock);
>>  
>>  	/* Bus width */
>> -	val = readl(host->regs + SD_EMMC_CFG);
>>  	switch (ios->bus_width) {
>>  	case MMC_BUS_WIDTH_1:
>>  		bus_width = CFG_BUS_WIDTH_1;
>> @@ -394,7 +393,6 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>>  		dev_err(host->dev, "Invalid ios->bus_width: %u.  Setting to 4.\n",
>>  			ios->bus_width);
>>  		bus_width = CFG_BUS_WIDTH_4;
>> -		return;
> 
> It's a different question..why does meson-gx-mmc use 4bit buswidth for invalid bus-with? not using 1bit-buswidth?
> 
I think this question is best addressed to Kevin as original author.

> Best Regards,
> Jaehoon Chung
> 
>>  	}
>>  
>>  	val = readl(host->regs + SD_EMMC_CFG);
>>
> 
>