[PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based binding to json schema

[PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based binding to json schema

[Charan Pedumuru]

Convert TI Highspeed MMC host controller binding to YAML format. Add
'clocks' property to resolve errors identified by 'dtb_check'.

Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
---
 .../devicetree/bindings/mmc/davinci_mmc.txt        | 32 -----------
 .../devicetree/bindings/mmc/ti,da830-mmc.yaml      | 62 ++++++++++++++++++++++
 2 files changed, 62 insertions(+), 32 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/davinci_mmc.txt b/Documentation/devicetree/bindings/mmc/davinci_mmc.txt
deleted file mode 100644
index 516fb0143d4c21d1c8e44a8846d55ea5458d7b74..0000000000000000000000000000000000000000
--- a/Documentation/devicetree/bindings/mmc/davinci_mmc.txt
+++ /dev/null
@@ -1,32 +0,0 @@
-* TI Highspeed MMC host controller for DaVinci
-
-The Highspeed MMC Host Controller on TI DaVinci family
-provides an interface for MMC, SD and SDIO types of memory cards.
-
-This file documents the properties used by the davinci_mmc driver.
-
-Required properties:
-- compatible:
- Should be "ti,da830-mmc": for da830, da850, dm365
- Should be "ti,dm355-mmc": for dm355, dm644x
-
-Optional properties:
-- bus-width: Number of data lines, can be <1>, <4>, or <8>, default <1>
-- max-frequency: Maximum operating clock frequency, default 25MHz.
-- dmas: List of DMA specifiers with the controller specific format
-	as described in the generic DMA client binding. A tx and rx
-	specifier is required.
-- dma-names: RX and TX  DMA request names. These strings correspond
-	1:1 with the DMA specifiers listed in dmas.
-
-Example:
-mmc0: mmc@1c40000 {
-	compatible = "ti,da830-mmc",
-	reg = <0x40000 0x1000>;
-	interrupts = <16>;
-	bus-width = <4>;
-	max-frequency = <50000000>;
-	dmas = <&edma 16
-		&edma 17>;
-	dma-names = "rx", "tx";
-};
diff --git a/Documentation/devicetree/bindings/mmc/ti,da830-mmc.yaml b/Documentation/devicetree/bindings/mmc/ti,da830-mmc.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..2be2ad0bdd14693208c2d6b94cc9257ab3209635
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/ti,da830-mmc.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/ti,da830-mmc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI Highspeed MMC host controller for DaVinci
+
+description:
+  The Highspeed MMC Host Controller on TI DaVinci family
+  provides an interface for MMC, SD and SDIO types of memory cards.
+
+allOf:
+  - $ref: mmc-controller.yaml
+
+maintainers:
+  - Rob Herring <robh@kernel.org>
+
+properties:
+  compatible:
+    enum:
+      - ti,da830-mmc
+      - ti,dm355-mmc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 2
+
+  dmas:
+    maxItems: 2
+
+  dma-names:
+    items:
+      - const: rx
+      - const: tx
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    mmc@1c40000 {
+        compatible = "ti,da830-mmc";
+        reg = <0x40000 0x1000>;
+        interrupts = <16 IRQ_TYPE_LEVEL_HIGH>,
+                     <17 IRQ_TYPE_LEVEL_HIGH>;
+        bus-width = <4>;
+        max-frequency = <50000000>;
+        dmas = <&edma 16>, <&edma 17>;
+        dma-names = "rx", "tx";
+    };
+...

---
base-commit: 7bac2c97af4078d7a627500c9bcdd5b033f97718
change-id: 20250523-davinci-mmc-c704440c3dd0

Best regards,
-- 
Charan Pedumuru <charan.pedumuru@gmail.com>

Re: [PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based binding to json schema

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

On Fri, May 23, 2025 at 01:34:10PM +0000, Charan Pedumuru wrote:
> Convert TI Highspeed MMC host controller binding to YAML format. Add
> 'clocks' property to resolve errors identified by 'dtb_check'.
> 
> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based binding to json schema

[Krzysztof Kozlowski]

On 23/05/2025 15:34, Charan Pedumuru wrote:
> Convert TI Highspeed MMC host controller binding to YAML format. Add
> 'clocks' property to resolve errors identified by 'dtb_check'.
> 
> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
> ---
>  .../devicetree/bindings/mmc/davinci_mmc.txt        | 32 -----------
>  .../devicetree/bindings/mmc/ti,da830-mmc.yaml      | 62 ++++++++++++++++++++++
>  2 files changed, 62 insertions(+), 32 deletions(-)
> 


A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

"convert to DT Schema"



...

> +
> +allOf:
> +  - $ref: mmc-controller.yaml
> +
> +maintainers:
> +  - Rob Herring <robh@kernel.org>

No, I really doubt Rob cares about this hardware.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,da830-mmc
> +      - ti,dm355-mmc
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 2
> +

This wasn't in original binding. You need to document this in the commit
msg. Also, list the items.

> +  dmas:
> +    maxItems: 2
> +
> +  dma-names:
> +    items:
> +      - const: rx
> +      - const: tx
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts

why interrupts are required?


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based binding to json schema

[Charan Pedumuru]

On 28-05-2025 13:32, Krzysztof Kozlowski wrote:
> On 23/05/2025 15:34, Charan Pedumuru wrote:
>> Convert TI Highspeed MMC host controller binding to YAML format. Add
>> 'clocks' property to resolve errors identified by 'dtb_check'.
>>
>> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
>> ---
>>  .../devicetree/bindings/mmc/davinci_mmc.txt        | 32 -----------
>>  .../devicetree/bindings/mmc/ti,da830-mmc.yaml      | 62 ++++++++++++++++++++++
>>  2 files changed, 62 insertions(+), 32 deletions(-)
>>
> 
> 
> A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
> prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> 
> "convert to DT Schema"

Sure, will change that.

> 
> 
> 
> ...
> 
>> +
>> +allOf:
>> +  - $ref: mmc-controller.yaml
>> +
>> +maintainers:
>> +  - Rob Herring <robh@kernel.org>
> 
> No, I really doubt Rob cares about this hardware.

I will remove Rob from maintainers and add Ulf under the maintainers.

> 
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - ti,da830-mmc
>> +      - ti,dm355-mmc
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 2
>> +
> 
> This wasn't in original binding. You need to document this in the commit
> msg. Also, list the items.

Sure, but what list of items for interrupts?

> 
>> +  dmas:
>> +    maxItems: 2
>> +
>> +  dma-names:
>> +    items:
>> +      - const: rx
>> +      - const: tx
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
> 
> why interrupts are required?

It is not necessary, will remove it from required.

> 
> 
> Best regards,
> Krzysztof

-- 
Best Regards,
Charan.

Re: [PATCH] dt-bindings: mmc: ti,da830-mmc: convert text based binding to json schema

[Krzysztof Kozlowski]

On 12/07/2025 10:22, Charan Pedumuru wrote:
>>> +
>>> +allOf:
>>> +  - $ref: mmc-controller.yaml
>>> +
>>> +maintainers:
>>> +  - Rob Herring <robh@kernel.org>
>>
>> No, I really doubt Rob cares about this hardware.
> 
> I will remove Rob from maintainers and add Ulf under the maintainers.

This should be someone responsible for this hardware, not subsystem
maintainer.

> 
>>
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - ti,da830-mmc
>>> +      - ti,dm355-mmc
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  clocks:
>>> +    maxItems: 1
>>> +
>>> +  interrupts:
>>> +    maxItems: 2
>>> +
>>
>> This wasn't in original binding. You need to document this in the commit
>> msg. Also, list the items.
> 
> Sure, but what list of items for interrupts?

List as a verb. You need to list them.


Best regards,
Krzysztof